Re: [PATCH] xen: Install unstripped version -syms version into /usr/lib/debug

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-06-26 at 10:48 +0100, Andrew Cooper wrote:
> > +BOOT_DIR defaults to /boot, DERBUG_DIR defaults to /usr/lib/debugt and
> 
> DERBUG and /debugt

Gah!

> > +EFI_DIR to /usr/lib64/efi.
> >  BOOT_DIR=
> > +DEBUG_DIR=
> >  EFI_DIR=
> >  
> >  The make target 'rpmball' will build a xen.rpm. This variable can be
> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
> > index f47c238..39d36b2 100644
> > --- a/config/StdGNU.mk
> > +++ b/config/StdGNU.mk
> > @@ -27,6 +27,7 @@ INSTALL_DATA = $(INSTALL) -m0644 -p
> >  INSTALL_PROG = $(INSTALL) -m0755 -p
> >  
> >  BOOT_DIR ?= /boot
> > +DEBUG_DIR ?= /usr/lib/debug
> 
> While I hate to day it, this probably needs /local/ handling for
> non-system builds, and this sounds autoconf'y.  How stable is the path
> across different systems?

This is used in xen/Makefile so autoconf is off the cards. So far we
already have BOOT_DIR and EFI_DIR which are special in this way. IMHO
adding DEBUG_DIR is fine. I don't think we will need this for tools/*
since what should happen there is we install the unstripped things (if
asked to do so) as usual and then the rpm/deb packaging tools will take
care of creating the detached debug info if they care. Normal users will
just get the stripped or unstripped versions install depending on what
they asked for.

I looked on Debian and at some Fedora wiki page and they both appear to
use /usr/lib/debug.

Ian.

> 
> ~Andrew
> 
> >  
> >  SOCKET_LIBS =
> >  UTIL_LIBS = -lutil
> > diff --git a/config/SunOS.mk b/config/SunOS.mk
> > index 21ea0c2..86a384d 100644
> > --- a/config/SunOS.mk
> > +++ b/config/SunOS.mk
> > @@ -19,6 +19,7 @@ INSTALL_DATA = $(INSTALL) -m0644 -p
> >  INSTALL_PROG = $(INSTALL) -m0755 -p
> >  
> >  BOOT_DIR ?= /boot
> > +DEBUG_DIR ?= /usr/lib/debug
> >  
> >  SunOS_LIBDIR = /usr/sfw/lib
> >  SunOS_LIBDIR_x86_64 = /usr/sfw/lib/amd64
> > diff --git a/xen/Makefile b/xen/Makefile
> > index b51dd36..6305880 100644
> > --- a/xen/Makefile
> > +++ b/xen/Makefile
> > @@ -44,7 +44,8 @@ _install: $(TARGET)$(CONFIG_XEN_INSTALL_SUFFIX)
> >  	ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> >  	ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION)$(Z)
> >  	ln -f -s $(T)-$(XEN_FULLVERSION)$(Z) $(D)$(BOOT_DIR)/$(T)$(Z)
> > -	$(INSTALL_DATA) $(TARGET)-syms $(D)$(BOOT_DIR)/$(T)-syms-$(XEN_FULLVERSION)
> > +	[ -d "$(D)$(DEBUG_DIR)" ] || $(INSTALL_DIR) $(D)$(DEBUG_DIR)
> > +	$(INSTALL_DATA) $(TARGET)-syms $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION)
> >  	if [ -r $(TARGET).efi -a -n '$(EFI_DIR)' ]; then \
> >  		[ -d $(D)$(EFI_DIR) ] || $(INSTALL_DIR) $(D)$(EFI_DIR); \
> >  		$(INSTALL_DATA) $(TARGET).efi $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi; \
> > @@ -67,7 +68,7 @@ _uninstall:
> >  	rm -f $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION)$(Z)
> >  	rm -f $(D)$(BOOT_DIR)/$(T)-$(XEN_VERSION)$(Z)
> >  	rm -f $(D)$(BOOT_DIR)/$(T)$(Z)
> > -	rm -f $(D)$(BOOT_DIR)/$(T)-syms-$(XEN_FULLVERSION)
> > +	rm -f $(D)$(DEBUG_DIR)/$(T)-syms-$(XEN_FULLVERSION)
> >  	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_FULLVERSION).efi
> >  	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).$(XEN_SUBVERSION).efi
> >  	rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
>