From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [Xen-staging] [xen staging] libxl: ao abort: Handle
 SIGTERM in save/restore helper
Date: Fri, 26 Jun 2015 17:44:51 +0100
Message-ID: <1435337091.32500.211.camel@citrix.com>
References: <E1Z8W6A-0004wB-68@xenbits.xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <E1Z8W6A-0004wB-68@xenbits.xen.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: xen-devel@lists.xensource.com, Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Roger Pau Monne <roger.pau@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-06-26 at 16:03 +0000, patchbot@xen.org wrote:
> commit b6ac9b7fc6bb18057a1aa114296b32f59b40e187
> Author:     Ian Jackson <ian.jackson@eu.citrix.com>
> AuthorDate: Tue Feb 10 19:05:06 2015 +0000
> Commit:     Ian Jackson <Ian.Jackson@eu.citrix.com>
> CommitDate: Fri Jun 26 16:53:51 2015 +0100
> 
>     libxl: ao abort: Handle SIGTERM in save/restore helper

Trying to do a build test of my libxenctrl split on FreeBSD I came
across this build failure with current staging (without my patches)
which I suspect is down to this change. Missing a header perhaps?

libxl_save_helper.c: In function 'setup_signals':
libxl_save_helper.c:158:22: error: storage size of 'sa' isn't known
     struct sigaction sa;
                      ^
libxl_save_helper.c:167:5: error: implicit declaration of function 'sigemptyset' [-Werror=implicit-function-declaration]
     sigemptyset(&sa.sa_mask);
     ^
libxl_save_helper.c:168:5: error: implicit declaration of function 'sigaction' [-Werror=implicit-function-declaration]
     r = sigaction(SIGTERM, &sa, 0);
     ^
libxl_save_helper.c:168:19: error: 'SIGTERM' undeclared (first use in this function)
     r = sigaction(SIGTERM, &sa, 0);
                   ^
libxl_save_helper.c:168:19: note: each undeclared identifier is reported only once for each function it appears in
libxl_save_helper.c:172:5: error: implicit declaration of function 'sigaddset' [-Werror=implicit-function-declaration]
     sigaddset(&spmask,SIGTERM);
     ^
libxl_save_helper.c:173:5: error: implicit declaration of function 'sigprocmask' [-Werror=implicit-function-declaration]
     r = sigprocmask(SIG_UNBLOCK,&spmask,0);
     ^
libxl_save_helper.c:173:21: error: 'SIG_UNBLOCK' undeclared (first use in this function)
     r = sigprocmask(SIG_UNBLOCK,&spmask,0);
                     ^
libxl_save_helper.c:158:22: error: unused variable 'sa' [-Werror=unused-variable]
     struct sigaction sa;
                      ^
libxl_save_helper.c: In function 'main':
libxl_save_helper.c:313:23: error: 'SIG_DFL' undeclared (first use in this function)
         setup_signals(SIG_DFL);
                       ^
cc1: all warnings being treated as errors