Re: [all better] Re: regression: massive trouble with fpu rework

[Mike Galbraith <umgwanakikbuti@gmail.com>]

On Mon, 2015-06-29 at 08:40 +0200, Ingo Molnar wrote:
> *
> Ok, so could you please move the fpu__init_system() further up and see which 
> position is that starts breaking with the BIOS option set?
> 
> here's the current, broken layout of the code:
> 
>         get_cpu_cap(c);
> [0]     fpu__init_system(c);
> 
>         if (this_cpu->c_early_init)
>                 this_cpu->c_early_init(c);
> 
> [1]
>         c->cpu_index = 0;
> [2]
>         filter_cpuid_features(c, false);
> 
> [3]
>         if (this_cpu->c_bsp_init)
>                 this_cpu->c_bsp_init(c);
> 
> [4]
>         setup_force_cpu_cap(X86_FEATURE_ALWAYS);
> [5]
> }
> 
> and we know it from your testing that moving [0] to [5] fixes the crash.
> 
> The question is, can we move it to [4], [3], [2] or even [1] instead, without 
> breaking the system?
> 
> I still don't see where the breakage comes from, but this would help us narrow it 
> down.

[0] is the only spot that breaks box.

	-Mike