diff for duplicates of <1435574617.11963.0.camel@neuling.org> diff --git a/a/1.txt b/N1/1.txt index cdf8be0..a6c6516 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,9 @@ On Mon, 2015-06-29 at 16:05 +0530, Maninder Singh wrote: > static Anlaysis detected below error:- > (error) Possible null pointer dereference: phb ->=20 +> > So, Use phb after NULL check. ->=20 +> > Signed-off-by: Maninder Singh <maninder1.s@samsung.com> Thanks, looks good. @@ -13,21 +13,20 @@ Acked-By: Michael Neuling <mikey@neuling.org> > --- > drivers/misc/cxl/vphb.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) ->=20 +> > diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c > index b1d1983a..2eba002 100644 > --- a/drivers/misc/cxl/vphb.c > +++ b/drivers/misc/cxl/vphb.c -> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus,= - unsigned int devfn, +> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn, > unsigned long addr; -> =20 -> phb =3D pci_bus_to_host(bus); -> - afu =3D (struct cxl_afu *)phb->private_data; -> if (phb =3D=3D NULL) +> +> phb = pci_bus_to_host(bus); +> - afu = (struct cxl_afu *)phb->private_data; +> if (phb == NULL) > return PCIBIOS_DEVICE_NOT_FOUND; -> + afu =3D (struct cxl_afu *)phb->private_data; +> + afu = (struct cxl_afu *)phb->private_data; > + > if (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num) > return PCIBIOS_DEVICE_NOT_FOUND; -> if (offset >=3D (unsigned long)phb->cfg_data) +> if (offset >= (unsigned long)phb->cfg_data) diff --git a/a/content_digest b/N1/content_digest index 7ae4c89..4b3c9e4 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -12,9 +12,9 @@ "On Mon, 2015-06-29 at 16:05 +0530, Maninder Singh wrote:\n" "> static Anlaysis detected below error:-\n" "> (error) Possible null pointer dereference: phb\n" - ">=20\n" + "> \n" "> So, Use phb after NULL check.\n" - ">=20\n" + "> \n" "> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>\n" "\n" "Thanks, looks good.\n" @@ -24,23 +24,22 @@ "> ---\n" "> drivers/misc/cxl/vphb.c | 3 ++-\n" "> 1 file changed, 2 insertions(+), 1 deletion(-)\n" - ">=20\n" + "> \n" "> diff --git a/drivers/misc/cxl/vphb.c b/drivers/misc/cxl/vphb.c\n" "> index b1d1983a..2eba002 100644\n" "> --- a/drivers/misc/cxl/vphb.c\n" "> +++ b/drivers/misc/cxl/vphb.c\n" - "> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus,=\n" - " unsigned int devfn,\n" + "> @@ -112,9 +112,10 @@ static int cxl_pcie_config_info(struct pci_bus *bus, unsigned int devfn,\n" "> \tunsigned long addr;\n" - "> =20\n" - "> \tphb =3D pci_bus_to_host(bus);\n" - "> -\tafu =3D (struct cxl_afu *)phb->private_data;\n" - "> \tif (phb =3D=3D NULL)\n" + "> \n" + "> \tphb = pci_bus_to_host(bus);\n" + "> -\tafu = (struct cxl_afu *)phb->private_data;\n" + "> \tif (phb == NULL)\n" "> \t\treturn PCIBIOS_DEVICE_NOT_FOUND;\n" - "> +\tafu =3D (struct cxl_afu *)phb->private_data;\n" + "> +\tafu = (struct cxl_afu *)phb->private_data;\n" "> +\n" "> \tif (cxl_pcie_cfg_record(bus->number, devfn) > afu->crs_num)\n" "> \t\treturn PCIBIOS_DEVICE_NOT_FOUND;\n" - "> \tif (offset >=3D (unsigned long)phb->cfg_data)" + "> \tif (offset >= (unsigned long)phb->cfg_data)" -f39383e9fe4e6365e200b4bb78a9361a1cbf6615c1018ac59c89a551e5d87540 +11b96cf91bd55544e0ec5732102601d1728f2a9e02852747de6afb9a5efb30d4
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.