From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752983AbbF2LXe (ORCPT ); Mon, 29 Jun 2015 07:23:34 -0400 Received: from smtprelay0008.hostedemail.com ([216.40.44.8]:42681 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752980AbbF2LXd (ORCPT ); Mon, 29 Jun 2015 07:23:33 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1540:1593:1594:1711:1714:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3350:3622:3865:3866:4321:4605:5007:6261:10004:10400:10848:11026:11232:11473:11658:11914:12043:12114:12296:12438:12517:12519:12679:12740:13069:13255:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: birth41_18cc28065f43 X-Filterd-Recvd-Size: 1905 Message-ID: <1435577009.9587.53.camel@perches.com> Subject: Re: [PATCH perf/core] perf tools: Add missing break for PERF_RECORD_ITRACE_START From: Joe Perches To: Jiri Olsa Cc: Arnaldo Carvalho de Melo , Kan Liang , Adrian Hunter , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra Date: Mon, 29 Jun 2015 04:23:29 -0700 In-Reply-To: <1435576340-19346-1-git-send-email-jolsa@kernel.org> References: <1435576340-19346-1-git-send-email-jolsa@kernel.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2015-06-29 at 13:12 +0200, Jiri Olsa wrote: > Missing switch break since introduction of new event: > c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES [] > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c [] > @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, union perf_event *event, > case PERF_RECORD_AUX: > ret = machine__process_aux_event(machine, event); break; > case PERF_RECORD_ITRACE_START: > - ret = machine__process_itrace_start_event(machine, event); > + ret = machine__process_itrace_start_event(machine, event); break; > case PERF_RECORD_LOST_SAMPLES: > ret = machine__process_lost_samples_event(machine, event, sample); break; > break; trivia: There's a duplicate/unreachable break; on the PERF_RECORD_LOST_SAMPLES case