From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC PATCH v3 09/18] xen/arm: ITS: Add virtual ITS
 commands support
Date: Mon, 29 Jun 2015 13:16:09 +0100
Message-ID: <1435580169.32500.297.camel@citrix.com>
References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com>
	<1434974517-12136-10-git-send-email-vijay.kilari@gmail.com>
	<558A8680.1030104@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <558A8680.1030104@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-24 at 11:29 +0100, Julien Grall wrote:

> > +    if ( virt_cmd->mapd.valid )
> > +    {
> > +        /* itt field is 40 bit. extract 48 bit address by shifting */
> > +        dt_entry.vitt_ipa = virt_cmd->mapd.itt << 8;
> > +
> > +        dt_entry.vitt_size = (1 << (virt_cmd->mapd.size + 1)) * 8;
> 
> Where does come from the 8? Is it the size of the ITT? If so, you should
> use the proper define.

sizeof(struct vitt) is what was meant, I think?

Ian.