From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [RFC PATCH v3 10/18] xen/arm: ITS: Add APIs to add
 and assign device
Date: Mon, 29 Jun 2015 13:25:25 +0100
Message-ID: <1435580725.32500.303.camel@citrix.com>
References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com>
	<1434974517-12136-11-git-send-email-vijay.kilari@gmail.com>
	<558A96A1.8070300@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <558A96A1.8070300@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K <Vijaya.Kumar@caviumnetworks.com>, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-06-24 at 12:38 +0100, Julien Grall wrote:
[...]
> > @@ -459,7 +475,7 @@ void its_send_inv(struct its_device *dev, struct its_collection *col,
> >      its_send_single_command(dev->its, its_build_inv_cmd, &desc);
> >  }
> >  
> > -void its_send_mapd(struct its_device *dev, int valid)
> > +static void its_send_mapd(struct its_device *dev, int valid)
> 
> I would prefer to see this static where the function has been introduced
> and delay the compilation until the end.

Yes, please.