From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [RFC PATCH v3 15/18] xen/arm: ITS: Add domain specific ITS initialization Date: Mon, 29 Jun 2015 14:01:38 +0100 Message-ID: <1435582898.32500.320.camel@citrix.com> References: <1434974517-12136-1-git-send-email-vijay.kilari@gmail.com> <1434974517-12136-16-git-send-email-vijay.kilari@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1434974517-12136-16-git-send-email-vijay.kilari@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: vijay.kilari@gmail.com Cc: stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, Vijaya Kumar K , tim@xen.org, xen-devel@lists.xen.org, julien.grall@citrix.com, stefano.stabellini@citrix.com, manish.jaggi@caviumnetworks.com List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-22 at 17:31 +0530, vijay.kilari@gmail.com wrote: > From: Vijaya Kumar K > > Add Domain and vcpu specific ITS initialization > > Signed-off-by: Vijaya Kumar K > --- > xen/arch/arm/gic-v3-its.c | 17 ++++++++++++++++ > xen/arch/arm/setup.c | 1 + > xen/arch/arm/vgic-v3-its.c | 45 +++++++++++++++++++++++++++++++++++++++++ > xen/arch/arm/vgic-v3.c | 1 + > xen/include/asm-arm/gic-its.h | 3 +++ > xen/include/asm-arm/vgic.h | 1 + > 6 files changed, 68 insertions(+) > > diff --git a/xen/arch/arm/gic-v3-its.c b/xen/arch/arm/gic-v3-its.c > index 4471669..8aa1ec5 100644 > --- a/xen/arch/arm/gic-v3-its.c > +++ b/xen/arch/arm/gic-v3-its.c > @@ -1234,6 +1234,23 @@ static int its_force_quiescent(void __iomem *base) > } > } > > +void its_domain_init(struct domain *d) > +{ > + struct its_node *its; > + > + if ( is_hardware_domain(d) ) > + { > + list_for_each_entry(its, &its_nodes, entry) > + { > + /* XXX: Assign only first physical ITS address */ I think we settled upon rewriting the msi-parent properties in the dts to all refer to a single vits, in which case putting that vits in the first pits' hole seem ok. Rather than an XXX (which is a TODO) a comment explaining what is going on would be preferable. Ian