All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: Suketu Shah <suketu.j.shah@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915/skl: Remove of the DC5 code
Date: Mon, 29 Jun 2015 20:08:59 +0300	[thread overview]
Message-ID: <1435597739.21822.8.camel@intel.com> (raw)
In-Reply-To: <20150629165906.GB1435@strange.ger.corp.intel.com>

On Mon, 2015-06-29 at 17:59 +0100, Damien Lespiau wrote:
> On Mon, Jun 29, 2015 at 07:54:42PM +0300, Imre Deak wrote:
> > On Mon, 2015-06-29 at 17:44 +0100, Damien Lespiau wrote:
> > > This code is all dead code since we want to go up to DC6, always.
> > 
> > On BXT DC6 is not available, so we can only go to DC5. It's disabled on
> > BXT atm, since runtime PM isn't enabled either.
> 
> I knew there was a catch!
> 
> That code is pretty convoluted btw, it would make sense to have proper
> pre_disable/post_enabled hooks on power wells?

Yes, it would make sense to simplify the code. I haven't thought about
adding new hooks, not sure how useful they would be on other platforms.
But to me it seems that the enable/disable parts in skl_set_power_well()
could be split out to the existing skl_power_well_{enable,disable}, have
you looked into that already?

--Imre

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-06-29 17:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 16:44 [PATCH 1/2] drm/i915/skl: Remove of the DC5 code Damien Lespiau
2015-06-29 16:44 ` [PATCH 2/2] drm/i915/skl: Don't try to disable DC6 if the DMC firwmare isn't loaded Damien Lespiau
2015-06-30  9:38   ` shuang.he
2015-06-29 16:54 ` [PATCH 1/2] drm/i915/skl: Remove of the DC5 code Imre Deak
2015-06-29 16:59   ` Damien Lespiau
2015-06-29 17:08     ` Imre Deak [this message]
2015-06-29 17:19       ` Damien Lespiau
2015-06-29 17:15 ` Kamath, Sunil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435597739.21822.8.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=suketu.j.shah@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.