Re: [PATCH v7 06/10] trace: Add lock-free tracing_map

[Tom Zanussi <tom.zanussi@linux.intel.com>]

On Fri, 2015-06-12 at 16:52 -0400, Steven Rostedt wrote:
> On Mon,  8 Jun 2015 16:32:05 -0500
> Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> 
> > +/**
> > + * tracing_map_init - Allocate and clear a map's tracing_map_elts
> > + * @map: The tracing_map to initialize
> > + *
> > + * Creates and sets up a map to contain a max_size number of entries
> > + * equal to a size of 2 ** map_bits.  Before using, the map fields
> > + * should be added to the map with tracing_map_add_key_field() and
> > + * tracing_map_add_key_field().  tracing_map_init() should then be
> 
> Hmm, it's suppose to be added with tracing_map_add_key_field() twice?
> 

Also fixed in the new version, coming shortly, thanks for the input.

Tom


> -- Steve
> 
> > + * called to allocate the array of tracing_map_elts, in order to avoid
> > + * allocating anything in the map insertion path.  The user-specified
> > + * map_size reflect the max number of entries requested by the user -
> > + * internally we double that in order to keep the table sparse and
> > + * keep collisions manageable.
> > + *
> > + * See tracing_map.h for a description of tracing_map_ops.
> > + *
> > + * Return: the tracing_map * if successful, ERR_PTR if not.
> > + */