From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 03/13] Reporting: sg-report-flight:
 Fix undefined value in $worstrow[]
Date: Tue, 30 Jun 2015 10:04:44 +0100
Message-ID: <1435655084.21469.29.camel@citrix.com>
References: <1435598089-21647-1-git-send-email-ian.jackson@eu.citrix.com>
	<1435598089-21647-4-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9rTV-00022L-T4
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 09:05:05 +0000
In-Reply-To: <1435598089-21647-4-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
> The fallback entry in the worstrow search, used when a job has not
> been run at all, was wrong.  Also, fix the doc comment which induced
> the mistake.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
>  sg-report-flight |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sg-report-flight b/sg-report-flight
> index 6481521..117b609 100755
> --- a/sg-report-flight
> +++ b/sg-report-flight
> @@ -965,7 +965,7 @@ END
>  
>      my $cell_html = sub {
>  	my ($ei, $core_only) = @_;
> -	# => ($h, $priority);
> +	# => ($h, $priority, $ch);

This is a 3-tuple.

>  	my $s= $ei->{Step};
>  	my $sum_core= $ei->{SummaryCore};
>  	$sum_core= $ei->{Summary} if !defined $sum_core;
> @@ -998,7 +998,7 @@ END
>      my @worstrow1;
>      my @worstrow2;
>      foreach my $col (@cols) {
> -	my @worst=(' bgcolor="#444444">',0);
> +	my @worst=('',0,'bgcolor="#444444"','');

But this is a 4-tuple. Is there still a disconnect?

Ah no, out of context here there is a @worst=@this followed by a "push
@worst". So this change is correct, but perhaps a comment would help
clarify? e.g

# Result of $cell_html + Encoded string of failing stepid

?

Ian.