From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [OSSTEST PATCH 05/13] Reporting: report_run_getinfo produces ColourAttr Date: Tue, 30 Jun 2015 10:06:58 +0100 Message-ID: <1435655218.21469.31.camel@citrix.com> References: <1435598089-21647-1-git-send-email-ian.jackson@eu.citrix.com> <1435598089-21647-6-git-send-email-ian.jackson@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z9rVm-0002Jn-Rn for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 09:07:26 +0000 In-Reply-To: <1435598089-21647-6-git-send-email-ian.jackson@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote: > This includes the bgcolour attribute name and the quotes. This will > make it possible for this function to sometimes not set a background > for the whole table cell in the future (which will be part of putting > multiple step results in each cell). > > No functional change. > > Signed-off-by: Ian Jackson > --- > Osstest/Executive.pm | 5 ++++- > sg-report-host-history | 2 +- > sg-report-job-history | 3 +-- > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Osstest/Executive.pm b/Osstest/Executive.pm > index 2389eb2..f53d271 100644 > --- a/Osstest/Executive.pm > +++ b/Osstest/Executive.pm > @@ -205,7 +205,10 @@ sub report_run_getinfo ($) { > > my $single = sub { > my ($summary, $colour) = @_; > - return { Summary => $summary, Colour => $colour }; > + return { > + Summary => $summary, > + ColourAttr => " bgcolor=\"$colour\"", FWIW all the uses have a space before there $ri->{ColourAttr}, so strictly you don't need it here, I think. Nonetheless: Acked-by: Ian Campbell