From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 11/13] Reporting: In history tables,
 show multiple failure steps
Date: Tue, 30 Jun 2015 10:15:06 +0100
Message-ID: <1435655706.21469.39.camel@citrix.com>
References: <1435598089-21647-1-git-send-email-ian.jackson@eu.citrix.com>
	<1435598089-21647-12-git-send-email-ian.jackson@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9rdH-0003VE-UI
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 09:15:12 +0000
In-Reply-To: <1435598089-21647-12-git-send-email-ian.jackson@eu.citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
> In report_run_getinfo, used by sg-report-job-history and
> sg-report-host-history, make provision for reporting multiple failed
> steps.
> 
> The failed steps are put side by side (in a single table cell).  The
> cell background is set by the job status, but the individual steps may
> vary their colour, as seen in this example:
>   http://xenbits.xen.org/people/iwj/2015/linux-next.html
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

> +	    ColourAttr => " bgcolor=\"$failcolour\"",

Another possibly unnecessary space, FWIW.


> +	};
>      } elsif ($status eq 'blocked') {
>          return $single->("blocked", $purple),
>      } else {