From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 05/13] Reporting: report_run_getinfo
 produces ColourAttr
Date: Tue, 30 Jun 2015 10:34:54 +0100
Message-ID: <1435656894.21469.44.camel@citrix.com>
References: <1435598089-21647-1-git-send-email-ian.jackson@eu.citrix.com>
	<1435598089-21647-6-git-send-email-ian.jackson@eu.citrix.com>
	<1435655218.21469.31.camel@citrix.com>
	<21906.24694.162101.184425@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9rwR-0004gk-H1
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 09:34:59 +0000
In-Reply-To: <21906.24694.162101.184425@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-30 at 10:25 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 05/13] Reporting: report_run_getinfo produces ColourAttr"):
> > On Mon, 2015-06-29 at 18:14 +0100, Ian Jackson wrote:
> ...
> > > -	return { Summary => $summary, Colour => $colour };
> > > +	return {
> > > +	    Summary => $summary,
> > > +	    ColourAttr => " bgcolor=\"$colour\"",
> > 
> > FWIW all the uses have a space before there $ri->{ColourAttr}, so
> > strictly you don't need it here, I think.
> 
> Ah yes.
> 
> > Nonetheless:
> > 
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Thanks.  I will remove that space and keep your ack.

Sure. I spotted another later in the series which I commented on too.