From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [OSSTEST PATCH 08/13] Reporting: Break out
	report_blessingscond
Date: Tue, 30 Jun 2015 10:44:25 +0100
Message-ID: <1435657465.21469.51.camel@citrix.com>
References: <1435598089-21647-1-git-send-email-ian.jackson@eu.citrix.com>
	<1435598089-21647-9-git-send-email-ian.jackson@eu.citrix.com>
	<1435655479.21469.36.camel@citrix.com>
	<21906.25056.514009.551103@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9s5e-0005q7-S4
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 09:44:30 +0000
In-Reply-To: <21906.25056.514009.551103@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-30 at 10:31 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [OSSTEST PATCH 08/13] Reporting: Break out report_blessingscond"):
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> 
> Thanks.
> 
> > BTW, I noticed that your valid blessing regex here includes "-", which
> > is not allowed elsewhere, which breaks "./standalone make-flight -f
> > $branch $branch" for our common branch names meaning the flight name
> > needs some munging. A minor inconvenience, but if this check were moved
> > to a centralised helper it could be easily fixed...
> 
> I guess.  Do we have anywhere else that validates a blessing name ?
> This particular bit of code is just intended a safety catch to stop
> the SQL going wrong.
> 
> IMO `-' is valid in blessings.  Consider `commission-oseleta'.

I'm being very confused -- I was thinking of flight names, not blessing
names.

> > Or at least this was once the case, I can't see the problematic check
> > right now and haven't actually tried this for a while. Perhaps it got
> > fixed already and I didn't notice?
> 
> I'm not sure what check exactly you are referring to...

Neither was I right then (above and beyond s/blessing/flight/
confusion).

I've just done "./standalone -f xen-unstable xen-unstable" and it seems
to have worked but:

$ ./mg-show-flight-runvars xen-unstable
Died at ./mg-show-flight-runvars line 42.

Which is from:
        die unless @ARGV==1 && $ARGV[0] =~ m/^\w+$/;

I also notice that standalone-generate-flight-runvars is laundering out
the - too.

Ian.