From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2] remove now unnecessary gc from
 libxl__async_exec_start calls
Date: Tue, 30 Jun 2015 10:47:24 +0100
Message-ID: <1435657644.21469.54.camel@citrix.com>
References: <55925984.1080504@cn.fujitsu.com>	<55925F2B.50000@citrix.com>
	<21906.25633.308879.107153@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21906.25633.308879.107153@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>, Roger Pau Monne <roger.pau@citrix.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>, Yang Hongyang <yanghy@cn.fujitsu.com>, Wen Congyang <wency@cn.fujitsu.com>, xen devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-30 at 10:40 +0100, Ian Jackson wrote:
> Andrew Cooper writes ("Re: [Xen-devel] [PATCH v2] remove now unnecessary gc from libxl__async_exec_start calls"):
> > On 30/06/15 09:55, Wen Congyang wrote:
> > > These were removed in commit f5f8400f.
> ...
> > > -    rc = libxl__async_exec_start(gc, &dev->aodev.aes);
> > > +    rc = libxl__async_exec_start(&dev->aodev.aes);
> > 
> > Can OSS test be updated to build the remus bits of libxl?  This failure
> > should not have been able to pass the push gate.
> 
> I haven't investigated why this is disabled in osstest's builds.

Roger was jsut asking about libnl-dev and ts-xen-build-prep on IRC. I
suspect he may be investigating...

> Did you check one of its build logs ?  They contain the `configure'
> output.

Roger pointed at 
http://logs.test-lab.xenproject.org/osstest/logs/58974/build-amd64/5.ts-xen-build.log

Which has:
        Checking for LIBNL3... no
        configure: WARNING: Disabling support for Remus network buffering.
            Please install libnl3 libraries, command line tools and devel
            headers - version 3.2.8 or higher
        
But Wheezy has libnl-dev 1.1-7, which I think it might just be too old.
It also has libnl-3-dev which is 3.2.7 in Wheezy, i.e. still not quite
new enough.

Jessie has 3.2.24 which will be more than sufficient.

I think the upshot is that it is pointless installing libnl-dev on
Wheezy, at least for current Xen maybe older branches worked with older
libnl, I didn't check...

Ian.