From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v3 COLOPre 15/26] tools/libxl: Add back channel to allow migration target send data back Date: Tue, 30 Jun 2015 11:07:06 +0100 Message-ID: <1435658826.21469.66.camel@citrix.com> References: <1435213552-10556-1-git-send-email-yanghy@cn.fujitsu.com> <1435213552-10556-16-git-send-email-yanghy@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435213552-10556-16-git-send-email-yanghy@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Yang Hongyang Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote: > + * LIBXL_HAVE_DOMAIN_CREATE_RESTORE_SEND_FD 1 > + * > + * If this is defined, libxl_domain_create_restore()'s API has changed to > + * include a send_fd param which used for libxl migration back channel. ^is Perhaps also end the sentence with "during $foo operations"? Since it is not used for standard restore. > int libxl_domain_create_restore(libxl_ctx *ctx, libxl_domain_config *d_config, > - uint32_t *domid, int restore_fd, > + uint32_t *domid, int restore_fd, int send_fd, This is probably not a good idea, but what about "int fd[2]", i.e. mimicking pipe(2). I suspect this will just make things harder on callers, especially those who wish to work with both versions. Thoughts? Ian.