From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 03/15] xen/arm: vGIC: Export vgic_vN ops rather than add an indirection Date: Tue, 30 Jun 2015 13:45:00 +0100 Message-ID: <1435668300.21469.131.camel@citrix.com> References: <1435311269-3189-1-git-send-email-julien.grall@citrix.com> <1435311269-3189-4-git-send-email-julien.grall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Z9uuO-0002QN-TY for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 12:45:05 +0000 In-Reply-To: <1435311269-3189-4-git-send-email-julien.grall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-06-26 at 10:34 +0100, Julien Grall wrote: > The function vgic_vN_init only calls register_vgic_ops. As it will never > contain anything else, domain initialization code should be in the > callback domain_init, remove them and directly use the VGIC ops in the > commmon vGIC code. Too many m's in common. > +#define DEFINE_VGIC_OPS(version) \ > + extern const struct vgic_ops vgic_v##version##_ops; > +DEFINE_VGIC_OPS(2) > +#ifdef HAS_GICV3 > +DEFINE_VGIC_OPS(3) > +#endif > +#undef DEFINE_VGIC_OPS I think the macro is a bit unnecessary, to externs would have been just fine. Either way: Acked-by: Ian Campbell