From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 13/15] xen/arm: Merge gicv_setup with
	vgic_domain_init
Date: Tue, 30 Jun 2015 13:59:44 +0100
Message-ID: <1435669184.21469.140.camel@citrix.com>
References: <1435311269-3189-1-git-send-email-julien.grall@citrix.com>
	<1435311269-3189-14-git-send-email-julien.grall@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta3.messagelabs.com ([195.245.230.39])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9v9H-0003Ka-A6
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 13:00:27 +0000
In-Reply-To: <1435311269-3189-14-git-send-email-julien.grall@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, Zoltan Kiss <zoltan.kiss@huawei.com>
List-Id: xen-devel@lists.xenproject.org

On Fri, 2015-06-26 at 10:34 +0100, Julien Grall wrote:
> Currently, it's hard to decide whether a part of the domain
> initialization  should live in gicv_setup (part of the GIC
> driver) and domain_init (part of the vGIC driver).
> 
> The code to initialize the domain for a specific vGIC version is always
> the same no matter the version of the GIC.
> 
> Move all the domain initialization code for the vGIC in the respective
> domain_init callback of each vGIC drivers.
> 
> Signed-off-by: Julien Grall <julien.grall@citrix.com>
> Cc: Zoltan Kiss <zoltan.kiss@huawei.com>
> diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c
> index 341b6df..3c09c3e 100644
> --- a/xen/arch/arm/gic.c
> +++ b/xen/arch/arm/gic.c
> @@ -67,6 +67,11 @@ unsigned int gic_number_lines(void)
>      return gic_hw_ops->info->nr_lines;
>  }
>  
> +const struct gic_info *gic_info(void)
> +{
> +    return gic_hw_ops->info;

This doesn't seem to be used here. Is it a remnant of the previous
approach?

> +    if ( !platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) )

Perhaps the stride should be in the info struct?


Ian.