From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v2 13/15] xen/arm: Merge gicv_setup with
 vgic_domain_init
Date: Tue, 30 Jun 2015 14:56:38 +0100
Message-ID: <1435672598.21469.176.camel@citrix.com>
References: <1435311269-3189-1-git-send-email-julien.grall@citrix.com>
	<1435311269-3189-14-git-send-email-julien.grall@citrix.com>
	<1435669184.21469.140.camel@citrix.com> <55929ED5.6000207@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=616afaa02=Ian.Campbell@citrix.com>)
	id 1Z9w1s-00010b-FJ
	for xen-devel@lists.xenproject.org; Tue, 30 Jun 2015 13:56:52 +0000
In-Reply-To: <55929ED5.6000207@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, Zoltan Kiss <zoltan.kiss@huawei.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-06-30 at 14:51 +0100, Julien Grall wrote:

> >> +    if ( !platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) )
> > 
> > Perhaps the stride should be in the info struct?
> 
> This is not related to any GICvN configuration but an hardware bug on
> some platform (currently only xgene). And we are not immune to a similar
> bug on GICv3.
> 
> So I would prefer to keep the check in vgic_domain_init which is more
> self contained than spread it in different place.

OK.