From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2] xen: arm: Log a warning message when a deprecated hypercall is used Date: Tue, 30 Jun 2015 15:18:52 +0100 Message-ID: <1435673932.21469.188.camel@citrix.com> References: <1435318794-27330-1-git-send-email-ian.campbell@citrix.com> <558D652F.1050806@citrix.com> <1435330521.32500.198.camel@citrix.com> <558D68F8.2010000@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <558D68F8.2010000@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall Cc: Keir Fraser , stefano.stabellini@eu.citrix.com, Ard Biesheuvel , tim@xen.org, xen-devel@lists.xen.org, Jan Beulich , Anthony PERARD List-Id: xen-devel@lists.xenproject.org On Fri, 2015-06-26 at 17:00 +0200, Julien Grall wrote: > > On 26/06/2015 16:55, Ian Campbell wrote: > >>> + * Only use this for hypercalls which were deprecated (i.e. replaced > >>> + * by something else) before Xen on ARM was created, i.e. *not* for > >>> + * hypercalls which are simply not yet used on ARM. > >>> + */ > >>> +#define HYPERCALL_DEPRECATED(_name, _nr_args) \ > >> > >> I guess the parameter __nr_args is just here for completeness? > > > > It goes into the hypercall table and is used to clobber the arguments in > > debug mode, just like for a non-deprecated hypercall. > > Thanks, you can keep the Reviewed-by then. Applied, thanks.