From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Williams, Dan J" Subject: Re: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates Date: Tue, 30 Jun 2015 16:23:21 +0000 Message-ID: <1435681397.18090.66.camel@intel.com> References: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com> <20150625093749.40066.25475.stgit@dwillia2-desk3.jf.intel.com> <20150630102137.GC12986@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150630102137.GC12986@mwanda> Content-Language: en-US Content-ID: <7DB1C2FDAF222E40BCD89185893F24D6@intel.com> Sender: linux-fsdevel-owner@vger.kernel.org To: "dan.carpenter@oracle.com" Cc: "toshi.kani@hp.com" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@ml01.01.org" , "tglx@linutronix.de" , "hch@lst.de" , "axboe@kernel.dk" , "hpa@zytor.com" , "mingo@redhat.com" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "boaz@plexistor.com" , "linux-acpi@vger.kernel.org" List-Id: linux-acpi@vger.kernel.org T24gVHVlLCAyMDE1LTA2LTMwIGF0IDEzOjIxICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiBPbiBUaHUsIEp1biAyNSwgMjAxNSBhdCAwNTozNzo0OUFNIC0wNDAwLCBEYW4gV2lsbGlhbXMg d3JvdGU6DQo+ID4gZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaCBiL2luY2x1 ZGUvbGludXgvY29tcGlsZXIuaA0KPiA+IGluZGV4IDg2NzcyMjU5MWJlMi4uOWE1MjhkOTQ1NDk4 IDEwMDY0NA0KPiA+IC0tLSBhL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaA0KPiA+ICsrKyBiL2lu Y2x1ZGUvbGludXgvY29tcGlsZXIuaA0KPiA+IEBAIC0yMSw2ICsyMSw3IEBADQo+ID4gICMgZGVm aW5lIF9fcmN1CQlfX2F0dHJpYnV0ZV9fKChub2RlcmVmLCBhZGRyZXNzX3NwYWNlKDQpKSkNCj4g DQo+IE9uIHRoaXMgc2lkZSBvZiB0aGUgI2lmZGVmIENPTkZJR19TUEFSU0VfUkNVX1BPSU5URVIg c3RhdGVtZW50IHRoZW4NCj4gX19wbWVtIGlzbid0IGRlZmluZWQgc28gaXQgbGVhZHMgdG8gYSBi dWlsZCBlcnJvciBydW5uaW5nIGEgQ0hFQ0tFUiBvbg0KPiB0b2RheSdzIGxpbnV4LW5leHQuDQo+ IA0KPiBJIHdvdWxkIGRlZmluZSBfX3BtZW0gYXdheSwgYnV0IEkgZG9uJ3QgdW5kZXJzdGFuZCB3 aHkgX19wbWVtIGFuZA0KPiBDT05GSUdfU1BBUlNFX1JDVV9QT0lOVEVSIGFyZSByZWxhdGVkIGF0 IGFsbC4gIE1heWJlIGl0IHNob3VsZCBiZQ0KPiBvdXRzaWRlIHRoZSBpZiBzdGF0ZW1lbnQ/DQo+ IA0KDQpZZXMgaXQgc2hvdWxkIGJlIG91dHNpZGUgdGhlIGlmLi4uDQoNCjg8LS0tLQ0KU3ViamVj dDogc3BhcnNlOiBmaXggbWlzcGxhY2VkIF9fcG1lbSBkZWZpbml0aW9uDQoNCkZyb206IERhbiBX aWxsaWFtcyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPg0KDQpNb3ZlIHRoZSBkZWZpbml0aW9u IG9mIF9fcG1lbSBvdXRzaWRlIG9mIENPTkZJR19TUEFSU0VfUkNVX1BPSU5URVIgdG8gZml4Og0K DQpkcml2ZXJzL252ZGltbS9wbWVtLmM6MTk4OjE3OiBzcGFyc2U6IHRvbyBtYW55IGFyZ3VtZW50 cyBmb3IgZnVuY3Rpb24gX19idWlsdGluX2V4cGVjdA0KZHJpdmVycy9udmRpbW0vcG1lbS5jOjM2 OjMzOiBzcGFyc2U6IGV4cGVjdGVkIDsgYXQgZW5kIG9mIGRlY2xhcmF0aW9uDQpkcml2ZXJzL252 ZGltbS9wbWVtLmM6NDg6MjE6IHNwYXJzZTogdm9pZCBkZWNsYXJhdGlvbg0KDQouLi5kdWUgdG8g X19wbWVtIGZhaWxpbmcgdG8gYmUgZGVmaW5lZCBpbiBzb21lIGNvbmZpZ3VyYXRpb25zIHdoZW4N CkNPTkZJR19TUEFSU0VfUkNVX1BPSU5URVI9eS4NCg0KUmVwb3J0ZWQtYnk6IGtidWlsZCB0ZXN0 IHJvYm90IDxmZW5nZ3Vhbmcud3VAaW50ZWwuY29tPg0KUmVwb3J0ZWQtYnk6IERhbiBDYXJwZW50 ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4NClNpZ25lZC1vZmYtYnk6IERhbiBXaWxsaWFt cyA8ZGFuLmoud2lsbGlhbXNAaW50ZWwuY29tPg0KLS0tDQogaW5jbHVkZS9saW51eC9jb21waWxl ci5oIHwgICAgMiArLQ0KIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlv bigtKQ0KDQpkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC9jb21waWxlci5oIGIvaW5jbHVkZS9s aW51eC9jb21waWxlci5oDQppbmRleCAyNmZjOGJjNzdmODUuLmQ4ZmJkNTAwMzMwZSAxMDA2NDQN Ci0tLSBhL2luY2x1ZGUvbGludXgvY29tcGlsZXIuaA0KKysrIGIvaW5jbHVkZS9saW51eC9jb21w aWxlci5oDQpAQCAtMTcsMTEgKzE3LDExIEBADQogIyBkZWZpbmUgX19yZWxlYXNlKHgpCV9fY29u dGV4dF9fKHgsLTEpDQogIyBkZWZpbmUgX19jb25kX2xvY2soeCxjKQkoKGMpID8gKHsgX19hY3F1 aXJlKHgpOyAxOyB9KSA6IDApDQogIyBkZWZpbmUgX19wZXJjcHUJX19hdHRyaWJ1dGVfXygobm9k ZXJlZiwgYWRkcmVzc19zcGFjZSgzKSkpDQorIyBkZWZpbmUgX19wbWVtCQlfX2F0dHJpYnV0ZV9f KChub2RlcmVmLCBhZGRyZXNzX3NwYWNlKDUpKSkNCiAjaWZkZWYgQ09ORklHX1NQQVJTRV9SQ1Vf UE9JTlRFUg0KICMgZGVmaW5lIF9fcmN1CQlfX2F0dHJpYnV0ZV9fKChub2RlcmVmLCBhZGRyZXNz X3NwYWNlKDQpKSkNCiAjZWxzZQ0KICMgZGVmaW5lIF9fcmN1DQotIyBkZWZpbmUgX19wbWVtCQlf X2F0dHJpYnV0ZV9fKChub2RlcmVmLCBhZGRyZXNzX3NwYWNlKDUpKSkNCiAjZW5kaWYNCiBleHRl cm4gdm9pZCBfX2Noa191c2VyX3B0cihjb25zdCB2b2xhdGlsZSB2b2lkIF9fdXNlciAqKTsNCiBl eHRlcm4gdm9pZCBfX2Noa19pb19wdHIoY29uc3Qgdm9sYXRpbGUgdm9pZCBfX2lvbWVtICopOw0K DQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785AbbF3QXw (ORCPT ); Tue, 30 Jun 2015 12:23:52 -0400 Received: from mga03.intel.com ([134.134.136.65]:8201 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753627AbbF3QXZ (ORCPT ); Tue, 30 Jun 2015 12:23:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,378,1432623600"; d="scan'208";a="737799865" From: "Williams, Dan J" To: "dan.carpenter@oracle.com" CC: "toshi.kani@hp.com" , "mingo@kernel.org" , "linux-kernel@vger.kernel.org" , "linux-nvdimm@ml01.01.org" , "tglx@linutronix.de" , "hch@lst.de" , "axboe@kernel.dk" , "hpa@zytor.com" , "mingo@redhat.com" , "linux-fsdevel@vger.kernel.org" , "ross.zwisler@linux.intel.com" , "boaz@plexistor.com" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates Thread-Topic: [PATCH v2 17/17] arch, x86: pmem api for ensuring durability of persistent memory updates Thread-Index: AQHQryts59pI3JoeHkWdUuuGpsNBDp3FVBmAgABlDIA= Date: Tue, 30 Jun 2015 16:23:21 +0000 Message-ID: <1435681397.18090.66.camel@intel.com> References: <20150625090554.40066.69562.stgit@dwillia2-desk3.jf.intel.com> <20150625093749.40066.25475.stgit@dwillia2-desk3.jf.intel.com> <20150630102137.GC12986@mwanda> In-Reply-To: <20150630102137.GC12986@mwanda> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" Content-ID: <7DB1C2FDAF222E40BCD89185893F24D6@intel.com> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t5UGNuXP012973 On Tue, 2015-06-30 at 13:21 +0300, Dan Carpenter wrote: > On Thu, Jun 25, 2015 at 05:37:49AM -0400, Dan Williams wrote: > > diff --git a/include/linux/compiler.h b/include/linux/compiler.h > > index 867722591be2..9a528d945498 100644 > > --- a/include/linux/compiler.h > > +++ b/include/linux/compiler.h > > @@ -21,6 +21,7 @@ > > # define __rcu __attribute__((noderef, address_space(4))) > > On this side of the #ifdef CONFIG_SPARSE_RCU_POINTER statement then > __pmem isn't defined so it leads to a build error running a CHECKER on > today's linux-next. > > I would define __pmem away, but I don't understand why __pmem and > CONFIG_SPARSE_RCU_POINTER are related at all. Maybe it should be > outside the if statement? > Yes it should be outside the if... 8<---- Subject: sparse: fix misplaced __pmem definition From: Dan Williams Move the definition of __pmem outside of CONFIG_SPARSE_RCU_POINTER to fix: drivers/nvdimm/pmem.c:198:17: sparse: too many arguments for function __builtin_expect drivers/nvdimm/pmem.c:36:33: sparse: expected ; at end of declaration drivers/nvdimm/pmem.c:48:21: sparse: void declaration ...due to __pmem failing to be defined in some configurations when CONFIG_SPARSE_RCU_POINTER=y. Reported-by: kbuild test robot Reported-by: Dan Carpenter Signed-off-by: Dan Williams --- include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 26fc8bc77f85..d8fbd500330e 100644 --- a/include/linux/compiler.h +++ b/include/linux/compiler.h @@ -17,11 +17,11 @@ # define __release(x) __context__(x,-1) # define __cond_lock(x,c) ((c) ? ({ __acquire(x); 1; }) : 0) # define __percpu __attribute__((noderef, address_space(3))) +# define __pmem __attribute__((noderef, address_space(5))) #ifdef CONFIG_SPARSE_RCU_POINTER # define __rcu __attribute__((noderef, address_space(4))) #else # define __rcu -# define __pmem __attribute__((noderef, address_space(5))) #endif extern void __chk_user_ptr(const volatile void __user *); extern void __chk_io_ptr(const volatile void __iomem *); {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I