From: Joe Perches <joe@perches.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Julia Lawall <julia.lawall@lip6.fr>,
Andrew Morton <akpm@linux-foundation.org>
Subject: RFC: kernel coding style: prefer array to &array[0] ?
Date: Tue, 30 Jun 2015 10:35:46 -0700 [thread overview]
Message-ID: <1435685746.12101.18.camel@perches.com> (raw)
It seems most in-kernel uses are 'array' rather than '&array[0]'
Most of the time, using array is simpler to read than &array[0].
Exceptions exists when addresses for consecutive members are
used like func(&array[0], &array[1]);
Should this preference be put into checkpatch and/or CodingStyle?
Here's a possible checkpatch --strict addition
---
scripts/checkpatch.pl | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 90e1edc..362a9d8 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -5492,6 +5492,12 @@ sub process {
}
}
+# check for address of array[0] (not '&& array[0]' or &array[0].member)
+ if ($sline =~ /[^\&]&\s*($Ident\s*(?:(?:\-\>|\.)\s*$Ident\s*)*)\s*\[\s*0\s*\]\s*(?!\[|\.|\-\>)/) {
+ CHK("ADDRESSOF_ARRAY",
+ "Using addressof array '$1' index [0] may be simpler as '$1'\n" . $herecurr);
+ }
+
# check for semaphores initialized locked
if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
WARN("CONSIDER_COMPLETION",
next reply other threads:[~2015-06-30 17:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 17:35 Joe Perches [this message]
2015-07-01 6:10 ` RFC: kernel coding style: prefer array to &array[0] ? Julia Lawall
2015-07-01 11:54 ` Clemens Ladisch
2015-07-01 12:15 ` Dan Carpenter
2015-07-01 12:26 ` Julia Lawall
2015-07-01 14:53 ` Joe Perches
2015-07-01 22:33 ` Dmitry Torokhov
2015-07-01 23:04 ` Joe Perches
2015-07-05 21:28 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435685746.12101.18.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.