From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v3 COLOPre 09/26] tools/libxl: introduce
 enum type libxl_checkpointed_stream
Date: Wed, 1 Jul 2015 15:09:41 +0100
Message-ID: <1435759781.21469.288.camel@citrix.com>
References: <1435213552-10556-1-git-send-email-yanghy@cn.fujitsu.com>
	<1435213552-10556-10-git-send-email-yanghy@cn.fujitsu.com>
	<1435595439.32500.384.camel@citrix.com>
	<5592672D.4080703@cn.fujitsu.com>
	<1435661527.21469.88.camel@citrix.com>
	<55934ACD.8070503@cn.fujitsu.com>
	<1435747003.21469.247.camel@citrix.com>
	<5593EE89.6060705@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5593EE89.6060705@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Yang Hongyang <yanghy@cn.fujitsu.com>
Cc: wei.liu2@citrix.com, wency@cn.fujitsu.com, andrew.cooper3@citrix.com, yunhong.jiang@intel.com, eddie.dong@intel.com, xen-devel@lists.xen.org, guijianfeng@cn.fujitsu.com, rshriram@cs.ubc.ca, ian.jackson@eu.citrix.com
List-Id: xen-devel@lists.xenproject.org

On Wed, 2015-07-01 at 21:43 +0800, Yang Hongyang wrote:
> 
> On 07/01/2015 06:36 PM, Ian Campbell wrote:
> > On Wed, 2015-07-01 at 10:05 +0800, Yang Hongyang wrote:
> >>
> >> On 06/30/2015 06:52 PM, Ian Campbell wrote:
> >>> On Tue, 2015-06-30 at 17:53 +0800, Yang Hongyang wrote:
> >>>>
> >>>> On 06/30/2015 12:30 AM, Ian Campbell wrote:
> >>>>> On Thu, 2015-06-25 at 14:25 +0800, Yang Hongyang wrote:
> >>>>>> introduce enum type libxl_checkpointed_stream in IDL.
> >>>>>> rename the last argument of migrate_receive from "remus" to
> >>>>>> "checkpointed" since the semantics of this parameter has
> >>>>>> changed.
> >>>>>
> >>>>> I don't see anything here which is hitting the libxl API layer, it all
> >>>>> looks to be internal to xl. Is that going to change in a future patch
> >>>>> i.e. is something in libxl.h going to now accept a
> >>>>> libxl_checkpointed_stream?
> >>>>
> >>>> It is stored in restore_params.checkpointed_stream, does this a libxl API layer
> >>>> structure?
> >>>
> >>> Is that in a later patch? I didn't spot it if so.
> >>
> >> It's in the existing code:
> >>
> >> xl_cmdimpl.c create_domain()
> >
> > Ah sorry, since it didn't change it wasn't in the patch and my grep
> > seems to have missed it.
> >
> > But wait, libxl_domain_restore_params isn't changed here, shouldn't it
> > be? Otherwise params.checkpointed_stream is still an int. I suspect some
> > part of a later patch should appear here instead.
> 
> It better to be changed, but I'm not sure if this change will impact the
> existing users, if we do not change, there won't be problem at least.

It surely has to change eventually and other callers will have to be
updated to cope (and there should be LIBXL_HAVE_...).

If it's going to change it may as well be here.