diff for duplicates of <1435879310.7541.2.camel@codethink.co.uk> diff --git a/a/1.txt b/N1/1.txt index 4a532f1..9057167 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -14,8 +14,7 @@ On Wed, 2015-07-01 at 10:37 +0300, Laurent Pinchart wrote: > > + PORT_GP_32(3, PIN_IO_VOLTAGE, unused), > > + > > + /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> > + [RCAR_GP_PIN(5, 31) + 1] = -> +> > + [RCAR_GP_PIN(5, 31) + 1] > > I'm sorry but I still don't like this. gcc outputs a warning when overriding > an initializer if you enable -Wextra, which leads me to believe this construct > is dubious. It should at least be tested with LLVM. @@ -117,8 +116,7 @@ index 1137bbc810cd..1e59e1775374 100644 + PORT_GP_32(5, _GP_GPIO, unused), /* Pins not associated with a GPIO port, placed after all the GPIOs */ -- [RCAR_GP_PIN(5, 31) + 1] = - SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), +- [RCAR_GP_PIN(5, 31) + 1] SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), SH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15), SH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15), diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c diff --git a/a/content_digest b/N1/content_digest index 611d651..ff26ee2 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -3,7 +3,7 @@ "ref\06355006.FnTDFbP0bb@avalon\0" "From\0Ben Hutchings <ben.hutchings@codethink.co.uk>\0" "Subject\0Re: [PATCH v4 2/8] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI\0" - "Date\0Fri, 03 Jul 2015 00:21:50 +0100\0" + "Date\0Thu, 02 Jul 2015 23:21:50 +0000\0" "To\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Cc\0Ian Molton <ian@mnementh.co.uk>" linux-mmc@vger.kernel.org @@ -31,8 +31,7 @@ "> > +\tPORT_GP_32(3, PIN_IO_VOLTAGE, unused),\n" "> > +\n" "> > +\t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "> > +\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "> \n" + "> > +\t[RCAR_GP_PIN(5, 31) + 1] > \n" "> I'm sorry but I still don't like this. gcc outputs a warning when overriding \n" "> an initializer if you enable -Wextra, which leads me to believe this construct \n" "> is dubious. It should at least be tested with LLVM.\n" @@ -134,8 +133,7 @@ "+\tPORT_GP_32(5, _GP_GPIO, unused),\n" " \n" " \t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "-\t[RCAR_GP_PIN(5, 31) + 1] =\n" - " \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" + "-\t[RCAR_GP_PIN(5, 31) + 1] \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" " \tSH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15),\n" " \tSH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15),\n" "diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c\n" @@ -201,4 +199,4 @@ "\n" Ben. -e63e5cf2037f4f226ad38961a7b6205c31bd2edfd2ebf0df7b2de953ba2a4c96 +489411df0c8f9d7528181aa0d8dab33879aa8d0d903e6a1554a1e33e90b94cf9
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.