All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH 1/4] guest_find_domid: Set Vcpus correctly.
Date: Fri, 3 Jul 2015 09:52:30 +0100	[thread overview]
Message-ID: <1435913550.9447.15.camel@citrix.com> (raw)
In-Reply-To: <1435857067-10704-2-git-send-email-ian.jackson@eu.citrix.com>

On Thu, 2015-07-02 at 18:11 +0100, Ian Jackson wrote:
> The regexp was wrong, resulting in the last digit of the memory being
> mistaken for the number of vcpus (!)
> 
> The only consumer of this is ts-logs-capture.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>

Perhaps at some point in the future once xm is off the test radar we
could consider using xl list --format=json (nb, I didn't check the
concrete syntax) and using that.

> ---
>  Osstest/TestSupport.pm |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index b5994a4..66dc218 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -1918,7 +1918,7 @@ sub guest_find_domid ($$) {
>      return if defined $gho->{Domid};
>      my $list= target_cmd_output_root($ho,
>                  common_toolstack($ho)." list $gho->{Name}");
> -    $list =~ m/^(?!Name\s)(\S+)\s+(\d+)\s+(\d+)+(\d+)\s.*$/m
> +    $list =~ m/^(?!Name\s)(\S+)\s+(\d+)\s+(\d+)\s+(\d+)\s.*$/m
>          or die "domain list: $list";
>      $1 eq $gho->{Name} or die "domain list name $1 expected $gho->{Name}";
>      $gho->{MemUsed}= $3;

  reply	other threads:[~2015-07-03  8:52 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 17:11 [OSSTEST PATCH 0/4] Fix use of xenctx Ian Jackson
2015-07-02 17:11 ` [OSSTEST PATCH 1/4] guest_find_domid: Set Vcpus correctly Ian Jackson
2015-07-03  8:52   ` Ian Campbell [this message]
2015-07-02 17:11 ` [OSSTEST PATCH 2/4] ts-logs-capture: Find xenctx in /usr/local as well Ian Jackson
2015-07-03  8:52   ` Ian Campbell
2015-07-02 17:11 ` [OSSTEST PATCH 3/4] ts-logs-capture: Break out guest listing and do it earlier Ian Jackson
2015-07-03  8:54   ` Ian Campbell
2015-07-02 17:11 ` [OSSTEST PATCH 4/4] ts-logs-capture: Run xenctx earlier Ian Jackson
2015-07-03  8:55   ` Ian Campbell
2015-07-03 11:25     ` Ian Jackson
2015-07-03 11:49       ` [OSSTEST PATCH 1/6] guest_find_domid: Set Vcpus correctly Ian Jackson
2015-07-03 11:49         ` [OSSTEST PATCH 2/6] ts-logs-capture: Find xenctx in /usr/local as well Ian Jackson
2015-07-03 11:49         ` [OSSTEST PATCH 3/6] ts-logs-capture: Break out guest listing and do it earlier Ian Jackson
2015-07-03 11:49         ` [OSSTEST PATCH 4/6] ts-logs-capture: Run xenctx earlier Ian Jackson
2015-07-03 11:49         ` [OSSTEST PATCH 5/6] ts-logs-capture: Run xenctx twice for each guest vcpu Ian Jackson
2015-07-03 12:07           ` Ian Campbell
2015-07-03 11:49         ` [OSSTEST PATCH 6/6] ts-logs-capture: Explicitly set xenctx capture filename Ian Jackson
2015-07-03 12:08           ` Ian Campbell
2015-07-03 13:20             ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435913550.9447.15.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.