From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v5 1/6] xen: dt: add dt_for_each_irq_map helper Date: Fri, 3 Jul 2015 15:18:11 +0100 Message-ID: <1435933091.9447.124.camel@citrix.com> References: <1435931942.9447.113.camel@citrix.com> <1435931957-26227-1-git-send-email-ian.campbell@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1435931957-26227-1-git-send-email-ian.campbell@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org Cc: julien.grall@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On Fri, 2015-07-03 at 14:59 +0100, Ian Campbell wrote: > This function iterates over a nodes interrupt-map property and calls a > callback for each interrupt. For now it only supplies the translated > IRQ since my use case has no need of e.g. child unit address. These > can be added as needed by any future users. > > This follows much the same logic as dt_irq_map_raw when parsing the > interrupt-map, but doesn't walk up the tree doing the actual > translation and it iterates over all entries instead of just looking > for the first match. > > I looked into refactoring dt_irq_map_raw but I couldn't find a way > which I was confident in, plus I was reluctant to diverge from the > Linux roots of this function any further. > > Signed-off-by: Ian Campbell > Reviewed-by: Julien Grall Julien pointed out that after this R-by response on v4 there was also a bunch of comments which I had missed (i.e. the R-by was a typo). I've replied to those on v4. (Mostly responding here for my own benefit so I don't go and commit it at some point).