From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2 1/7] libxl: get rid of the SEDF scheduler Date: Fri, 3 Jul 2015 16:33:26 +0200 Message-ID: <1435934006.14347.75.camel@citrix.com> References: <20150703101558.5144.46511.stgit@Solace.station> <20150703102438.5144.35293.stgit@Solace.station> <1435933382.9447.127.camel@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5800845184647281542==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZB22B-0002Uw-Eu for xen-devel@lists.xenproject.org; Fri, 03 Jul 2015 14:33:43 +0000 In-Reply-To: <1435933382.9447.127.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: George Dunlap , xen-devel@lists.xenproject.org, Ian Jackson , Wei Liu , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============5800845184647281542== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-JCsmbG33Y9nsnzq49K7c" --=-JCsmbG33Y9nsnzq49K7c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, 2015-07-03 at 15:23 +0100, Ian Campbell wrote: > On Fri, 2015-07-03 at 12:24 +0200, Dario Faggioli wrote: >=20 > > @@ -5932,7 +5865,8 @@ int libxl_domain_sched_params_set(libxl_ctx *ctx,= uint32_t domid, > > =20 > > switch (sched) { > > case LIBXL_SCHEDULER_SEDF: > > - ret=3Dsched_sedf_domain_set(gc, domid, scinfo); > > + LOG(ERROR, "SEDF scheduler no longer available"); > > + ret=3DERROR_INVAL; >=20 > Should we have a specific error code for removed functionality? >=20 Good point: shall I introduce it? If yes, how should it be called? ERROR_REMOVED ERROR_DEPRECATED ERROR_GONE I think I'd go for _REMOVED, as deprecated suggests (to me at least) that it's still there but nshould not be used. Any other ideas? Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-JCsmbG33Y9nsnzq49K7c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWWnUAACgkQk4XaBE3IOsQnJgCfU4psD3oJTh8q+cPUDQcYNI/c EwYAniyFNXs4/fY7XFmHxN0p9LLZ0V5h =0BQ2 -----END PGP SIGNATURE----- --=-JCsmbG33Y9nsnzq49K7c-- --===============5800845184647281542== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5800845184647281542==--