From: Ian Campbell <ian.campbell@citrix.com>
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xen.org, stefano.stabellini@eu.citrix.com
Subject: Re: [PATCH v4 1/6] xen: dt: add dt_for_each_irq_map helper
Date: Fri, 3 Jul 2015 16:28:37 +0100 [thread overview]
Message-ID: <1435937317.9447.158.camel@citrix.com> (raw)
In-Reply-To: <5596A71C.4090509@citrix.com>
On Fri, 2015-07-03 at 16:15 +0100, Julien Grall wrote:
> >> The other caller of dt_irq_translate returns an error when ret is not 0.
> >> I would do the same here.
> >
> > dt_device_get_irq just returns the value of dt_irq_translate directly.
>
> But the caller of dt_device_get_irq is treating everything other than 0
> as an error.
>
> >
> > Are you suggesting this code should treat positive results as an error
> > as well as negative ones? I don't agree, this function has the normal 0
> > on success -ve on error semantics AFAICT.
>
> Well, it's not documented so it can be interpreted differently.
It's not documented, but it's pretty conventional throughout most Linux
interfaces...
> I
> personally interpreted as anything other than 0 is an error. This is how
> Linux behave on most of the of_* function and I think it's "safer".
...but it does look like of_* (which are dt_* in Xen) do indeed behave
that way so I shall change it.
I'm going to change the two cb invocations for consistency too.
Ian.
next prev parent reply other threads:[~2015-07-03 15:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-08 11:26 [PATCH v3 0/6] xen: arm: Parse PCI DT nodes' ranges and interrupt-map Ian Campbell
2015-05-08 11:26 ` [PATCH v4 1/6] xen: dt: add dt_for_each_irq_map helper Ian Campbell
2015-06-26 17:47 ` Julien Grall
2015-07-03 14:16 ` Ian Campbell
2015-07-03 15:15 ` Julien Grall
2015-07-03 15:28 ` Ian Campbell [this message]
2015-05-08 11:26 ` [PATCH v4 2/6] xen: dt: add dt_for_each_range helper Ian Campbell
2015-05-08 11:26 ` [PATCH v4 3/6] xen: arm: slightly refactor gic DT node creation for domain 0 Ian Campbell
2015-05-08 16:21 ` Ian Campbell
2015-05-08 11:26 ` [PATCH v4 4/6] xen: arm: drop redundant extra call to vgic_reserve_virq Ian Campbell
2015-06-26 17:49 ` Julien Grall
2015-05-08 11:26 ` [PATCH v4 5/6] xen: arm: map child MMIO and IRQs to dom0 for PCI bus DT nodes Ian Campbell
2015-06-26 17:56 ` Julien Grall
2015-07-03 10:59 ` Ian Campbell
2015-07-03 11:26 ` Julien Grall
2015-05-08 11:27 ` [PATCH v4 6/6] xen: arm: Import of_bus PCI entry from Linux (as a dt_bus entry) Ian Campbell
2015-06-26 18:08 ` Julien Grall
2015-07-03 10:47 ` Ian Campbell
2015-07-03 10:56 ` Ian Campbell
2015-07-03 11:24 ` Julien Grall
2015-07-03 11:30 ` Ian Campbell
2015-05-08 11:41 ` [PATCH v3 0/6] xen: arm: Parse PCI DT nodes' ranges and interrupt-map Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1435937317.9447.158.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=julien.grall@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.