Re: [PATCH] xen/arm: Remove unused field eoi_cpu in arch_irq_desc

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-06-26 at 16:54 +0100, Ian Campbell wrote:
> On Fri, 2015-06-26 at 16:43 +0100, Julien Grall wrote:
> > This field have been set but not used since Xen 4.5. Slim down Xen by
> > about 4K by removing it.
> > 
> > Also fix comment coding style.
> > 
> > Signed-off-by: Julien Grall <julien.grall@citrix.com>
> > ---
> >  xen/arch/arm/irq.c        | 7 ++++---
> >  xen/include/asm-arm/irq.h | 1 -
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> > index 2dd43ee..6bb076e 100644
> > --- a/xen/arch/arm/irq.c
> > +++ b/xen/arch/arm/irq.c
> > @@ -219,10 +219,11 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq)
> >          desc->handler->end(desc);
> >  
> >          set_bit(_IRQ_INPROGRESS, &desc->status);
> > -        desc->arch.eoi_cpu = smp_processor_id();
> >  
> > -        /* the irq cannot be a PPI, we only support delivery of SPIs to
> > -         * guests */
> > +        /*
> > +	 * The irq cannot be a PPI, we only support delivery of SPIs to
> > +         * guests.
> 
> Stray tab?
> 
> Otherwise LGTM: Acked-by: Ian Campbell <ian.campbell@citrix.com>

Applied.

> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel