From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZB6Hj-0002fe-F1 for mharc-grub-devel@gnu.org; Fri, 03 Jul 2015 15:06:03 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55098) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB6Hg-0002et-0b for grub-devel@gnu.org; Fri, 03 Jul 2015 15:06:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZB6Hb-0008Sd-Uh for grub-devel@gnu.org; Fri, 03 Jul 2015 15:05:59 -0400 Received: from mail-la0-x22a.google.com ([2a00:1450:4010:c03::22a]:34575) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZB6Hb-0008QZ-MU for grub-devel@gnu.org; Fri, 03 Jul 2015 15:05:55 -0400 Received: by lagx9 with SMTP id x9so94288003lag.1 for ; Fri, 03 Jul 2015 12:05:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=ulxltTpuqLhYUHmcpv50CvPDjghhuyaHPf2KZVYtD9Y=; b=bszPcnockTyW7Gj4Zi3p1aAejNDfVnBOyH8yDdUCSHwPr/Gv8bnHTwFyB6v809Q8aj pxF6+waNv9FPf5Xwr+w3+mIW0dvM68hQ0Yl7uqXUnruxDRIqlqKH4ePww9aL5oT/+pM+ gqqbd+4R1sN9BrOzoDfNnDaOCufbQ/HvA8YRDzqd1+7agpyb2nVtEhA8AjnYfC334hBj iEGU6s/feq1xX4CXD3VUzm6EajGD+4NDMBjAHnRqEsmdcur0b29T6KvTBnwWcjkeDQiM taXV5w8efvhBsEJy76i0gcHgThGWJvvAl6uDaHiIMT/b/GctdR6SYqmG+LdSfqxPTKbb SKeQ== X-Received: by 10.112.119.230 with SMTP id kx6mr27955584lbb.9.1435950354924; Fri, 03 Jul 2015 12:05:54 -0700 (PDT) Received: from opensuse.site.site (ppp91-76-14-38.pppoe.mtu-net.ru. [91.76.14.38]) by mx.google.com with ESMTPSA id df8sm2528449lac.3.2015.07.03.12.05.54 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 03 Jul 2015 12:05:54 -0700 (PDT) From: Andrei Borzenkov To: grub-devel@gnu.org Subject: [PATCH] zfs: fix compilation failure with clang due to alignment Date: Fri, 3 Jul 2015 22:05:47 +0300 Message-Id: <1435950347-20073-1-git-send-email-arvidjaar@gmail.com> X-Mailer: git-send-email 2.1.4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c03::22a Cc: jack@suse.cz X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jul 2015 19:06:01 -0000 I do not claim I understand why clang complains, but this patch does fix it. fs/xfs.c:452:25: error: cast from 'struct grub_xfs_btree_node *' to 'grub_uint64_t *' (aka 'unsigned long long *') increases required alignment from 1 to 8 [-Werror,-Wcast-align] grub_uint64_t *keys = (grub_uint64_t *)(leaf + 1); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. --- Jan, do you have any idea what's wrong and whether this is proper fix? Or should I raise it with clang? grub-core/fs/xfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/grub-core/fs/xfs.c b/grub-core/fs/xfs.c index 7249291..ea8cf7e 100644 --- a/grub-core/fs/xfs.c +++ b/grub-core/fs/xfs.c @@ -445,14 +445,14 @@ grub_xfs_next_de(struct grub_xfs_data *data, struct grub_xfs_dir2_entry *de) return (struct grub_xfs_dir2_entry *)(((char *)de) + ALIGN_UP(size, 8)); } -static grub_uint64_t * +static void * grub_xfs_btree_keys(struct grub_xfs_data *data, struct grub_xfs_btree_node *leaf) { - grub_uint64_t *keys = (grub_uint64_t *)(leaf + 1); + char *keys = (char *)leaf + sizeof (*leaf); if (data->hascrc) - keys += 6; /* skip crc, uuid, ... */ + keys += 6 * sizeof (grub_uint64_t); /* skip crc, uuid, ... */ return keys; } -- tg: (7a21030..) u/xfs-clang-align (depends on: master)