Re: [PATCH 1/1] mmc: block: don't use parameter prefix if built as module

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Wed, 2015-06-24 at 14:32 +0300, Andy Shevchenko wrote:
> It's excessive to use prefix for the parameters when you do
> 	modrpobe mmc-block mmcblk.perdev_minors=16
> 
> Make this available only for built-in case.

Any comments on this?

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/mmc/card/block.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index c9c3d20..b94540b 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -47,10 +47,13 @@
>  #include "queue.h"
>  
>  MODULE_ALIAS("mmc:block");
> +
> +#ifdef KERNEL
>  #ifdef MODULE_PARAM_PREFIX
>  #undef MODULE_PARAM_PREFIX
>  #endif
>  #define MODULE_PARAM_PREFIX "mmcblk."
> +#endif
>  
>  #define INAND_CMD38_ARG_EXT_CSD  113
>  #define INAND_CMD38_ARG_ERASE    0x00

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy