All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bastien Nocera <hadess@hadess.net>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: Why doesn't plugins/sixaxis.c set devices as Trusted?
Date: Mon, 06 Jul 2015 15:17:31 +0200	[thread overview]
Message-ID: <1436188651.26954.9.camel@hadess.net> (raw)

Hey,

I don't understand the reason why plugins/sixaxis.c doesn't set the
device as trusted when plugged in.

I would expect the Sixaxis plugin to do that, because there's no way to
assert, in the UI, where the device information is coming from to trust
it automatically, and I don't really want to show a "Do you want to
allow device X to connect as a HID device" for devices which weren't
setup in the UI.

For example, I could create a program on another computer with similar
characteristics (same name, class and service UUIDs) which would make
it indistinguishable from the device that was plugged in.

If security was a problem, we probably shouldn't be setting the master
BD address on the pad unless there's a running agent.

So, do we stop setup_device() early if there's no agent running and set
as trusted, or simply always set as trusted?

Cheers

             reply	other threads:[~2015-07-06 13:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 13:17 Bastien Nocera [this message]
2015-07-07  4:31 ` Why doesn't plugins/sixaxis.c set devices as Trusted? Alexander Holler
2015-07-07  5:11   ` Bastien Nocera
2015-07-07  5:34     ` Alexander Holler
2015-07-07  6:49       ` Alexander Holler
2015-07-07  5:35     ` Bastien Nocera
2015-07-07 14:16   ` Harald Schmitt
2015-07-09 20:26     ` Alexander Holler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436188651.26954.9.camel@hadess.net \
    --to=hadess@hadess.net \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=szymon.janc@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.