From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST 2/2] ts-debian-hvm-install: Arrange for installed guest to use a serial console Date: Mon, 6 Jul 2015 15:19:45 +0100 Message-ID: <1436192385.25646.94.camel@citrix.com> References: <1436190312-17566-1-git-send-email-ian.campbell@citrix.com> <1436190312-17566-2-git-send-email-ian.campbell@citrix.com> <21914.35160.252447.629825@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21914.35160.252447.629825@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-06 at 14:57 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST 2/2] ts-debian-hvm-install: Arrange for installed guest to use a serial console"): > > So that the guest boot will be logged somewhere useful (the qemu-dm > > log). > > > > It still seems to pickup a "quiet" from somewhere, so it's not as > > useful as it might be, but it is an improvement. > > Acked-by: Ian Jackson Thanks! This and the previous patch were born out of looking at flight 59040 and I think would be good to have in pretest sooner rather than later to see if they can help debug those failures. > I spotted that > > > sub grub_cfg () { > > sub isolinux_cfg () { > > these two functions are rather similar, but I shan't ask you to merge > them now. Thanks! They differ in ways which I think must be down to differences in the original ones which come from Debian. In any case I think they can probably both be convinced to use di_installcmdline_core like my distro series' ts-debian-di-install does, although perhaps with some adjustments. Ian.