Re: [PATCH OSSTEST v7 12/15] Add testing of non-LVM/phy disk backends.

[Ian Campbell <ian.campbell@citrix.com>]

On Mon, 2015-07-06 at 16:21 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v7 12/15] Add testing of non-LVM/phy disk backends."):
> > xen-create-image makes this tricky to do since it is rather LVM
> > centric. Now that we have the ability to install from d-i it's
> > possible to arrange fairly easily that they use non-LVM disk backend
> > arrangements.
> > 
> > Here we add support to the test script and infra and create a bunch of
> > new jobs testing the cross product of {xl,libvirt} x {raw,qcow2,vhd}.
> 
> This looks pretty good.
> 
> I have just two minor questions:
> 
> > +sub prepareguest_part_diskimg ($$$) {
> > +    my ($ho, $gho, $disk_mb) = @_;
> > +
> > +    my $diskfmt = $gho->{Diskfmt};
> > +    # Allow an extra 10 megabytes for image format headers
> > +    my $disk_overhead = $diskfmt eq "lvm" ? 0 : 10;
> > +
> > +    logm("preparing guest disks in $diskfmt format");
> > +
> > +    target_cmd_root($ho, "umount $gho->{Lvdev} ||:");
> 
> Does this not sometimes produce an undefined variable warning ?

I don't think so, but I'll keep a look out next time I run a flight.

> > diff --git a/make-flight b/make-flight
> > index 8206508..0313696 100755
> > --- a/make-flight
> > +++ b/make-flight
> > @@ -383,6 +383,22 @@ do_pv_debian_tests () {
> >    for xsm in $xsms ; do
> >      do_pv_debian_test_one libvirt '' libvirt enable_xsm=$xsm
> >    done
> > +
> > +  for ts in xl libvirt ; do
> > +
> > +    for fmt in raw vhd qcow2 ; do
> > +
> > +      fmt_runvar="debian_diskfmt=$fmt"
> > +
> > +      do_pv_debian_test_one $ts-$fmt '-di' $ts  \
> > +          debian_arch=$dom0arch                 \
> > +          debian_suite=$guestsuite              \
> > +          debian_method=netboot                 \
> > +          debian_bootloader=pygrub              \
> > +          $fmt_runvar
> 
> Are some of these jobs not very similar to existing ones ?

They differ in the backing store used for the guest's disks, but
otherwise they are quite similar to the existing flight, except they are
installed with d-i not xen-create-image.

The use of d-i is simply because it was easier to reuse
ts-debian-di-install than to convince xen-create-image to using non-LVM,
rather than a particular desire to test d-i in this context.

Ian.