From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] libxc: fix PV vNUMA guest memory allocation Date: Mon, 6 Jul 2015 18:11:43 +0200 Message-ID: <1436199103.10763.5.camel@citrix.com> References: <1436188640-303-3-git-send-email-wei.liu2@citrix.com> <1436190460-1354-1-git-send-email-wei.liu2@citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5764390177353255541==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZC8zv-0007Qk-K7 for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 16:11:59 +0000 In-Reply-To: <1436190460-1354-1-git-send-email-wei.liu2@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu Cc: Xen-devel , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org --===============5764390177353255541== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-KdLzu4KGlDSpl5pDvqGU" --=-KdLzu4KGlDSpl5pDvqGU Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-07-06 at 14:47 +0100, Wei Liu wrote: > In 415b58c1 (tools/libxc: Batch memory allocations for PV guests) the > number of super pages is calculated with the number of total pages. That > is wrong. It breaks PV guest vNUMA. The correct number of super pages > should be derived from the number of pages within that virtual NUMA > node. >=20 > Also change the name and type of super page variable to match the naming > convention and type of normal page variable. Make the necessary > adjustment to make code compile. >=20 > Reported-by: Dario Faggioli > Signed-off-by: Wei Liu > Reviewed-by: Ross Lagerwall > --- > v2: uint64_t for count variable for consistency, no functional changes wr= t v1 > so I retain the Reviewed-by tag. > --- > Reviewed-and-Tested-by: Dario Faggioli Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-KdLzu4KGlDSpl5pDvqGU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWaqMgACgkQk4XaBE3IOsSEOgCgqDjYsAWJEUO9YYoycwNiMnHq hfoAoIOn9OpNea0B2yQvXZOPcoUj+Mkz =FoW3 -----END PGP SIGNATURE----- --=-KdLzu4KGlDSpl5pDvqGU-- --===============5764390177353255541== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============5764390177353255541==--