From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 1/7] libxl: get rid of the SEDF scheduler Date: Mon, 6 Jul 2015 19:43:02 +0200 Message-ID: <1436204582.10763.47.camel@citrix.com> References: <20150706152620.12310.7021.stgit@Solace.station> <20150706153043.12310.43382.stgit@Solace.station> <559AA178.5030600@eu.citrix.com> <1436199470.10763.11.camel@citrix.com> <559AAB37.8010003@eu.citrix.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3779737122640155497==" Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZCAQA-0006Ib-M4 for xen-devel@lists.xenproject.org; Mon, 06 Jul 2015 17:43:10 +0000 In-Reply-To: <559AAB37.8010003@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: George Dunlap Cc: xen-devel@lists.xenproject.org, Ian Campbell , Wei Liu , Ian Jackson , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org --===============3779737122640155497== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-e5lOPwpJnt338l3bGOso" --=-e5lOPwpJnt338l3bGOso Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2015-07-06 at 17:22 +0100, George Dunlap wrote: > On 07/06/2015 05:17 PM, Dario Faggioli wrote: > > On Mon, 2015-07-06 at 16:40 +0100, George Dunlap wrote: > >> On 07/06/2015 04:30 PM, Dario Faggioli wrote: > >>> only the interface is left in place, for backward > >>> compile-time compatibility, but every attempt to > >>> use it would throw an error. > >>> > >>> Signed-off-by: Dario Faggioli > >>> Reviewed-by: George Dunlap > >> > >> This probably should have been dropped... > >> > >>> Chenges from v2: > >>> - introduce and use ERROR_FEATURE_REMOVED, as requested > >>> during review; > >>> - mark the SEDF only parameter as deprecated in libxl_types.idl, > >>> as requested during review. > >> > >> ...given these. One question: > >> > > Really? I'm basically only adding commentary, not changing (or adding, > > or removing) a single line of code... I mean, the deprecation was > > de-facto there already, since v1, it just was not stated explicitly > > anywhere in that particular file. > >=20 > > That's why I didn't think a something like adding this comment would > > call for removal of the tag. > >=20 > > Anyway, sorry for this. :-) >=20 > Not a big deal of course, and as it happens I wouldn't have minded if > the patch went in as it is. =20 > Sure! :-) I also was also just explaining my reasoning, rather than complaining. > But what if I hadn't liked the name of the > error code? It looks like I approve of it, which might sway some > maintainer's view, when in fact I haven't expressed an opinion. >=20 Indeed, I see it know. Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-e5lOPwpJnt338l3bGOso Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWaviYACgkQk4XaBE3IOsTz3QCfcWfoaWsrQaVIZINTc+P1TyUr KkUAn2s9zdPIO7nZkA8Ze6LQxhCTBzyu =2nWG -----END PGP SIGNATURE----- --=-e5lOPwpJnt338l3bGOso-- --===============3779737122640155497== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============3779737122640155497==--