From: Joe Perches <joe@perches.com>
To: Greg KH <greg@kroah.com>
Cc: Vasiliy Korchagin <vasiliy.korchagin@gmail.com>,
oleg.drokin@intel.com, devel@driverdev.osuosl.org,
andreas.dilger@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c
Date: Mon, 06 Jul 2015 22:01:11 -0700 [thread overview]
Message-ID: <1436245271.2682.32.camel@perches.com> (raw)
In-Reply-To: <20150707023652.GA9748@kroah.com>
On Mon, 2015-07-06 at 19:36 -0700, Greg KH wrote:
> On Fri, Jun 26, 2015 at 11:04:49PM -0700, Joe Perches wrote:
> > On Sat, 2015-06-27 at 06:36 +0100, Vasiliy Korchagin wrote:
[]
> > > Here is another version with macro expansion. Inline function expansion doesn't
> > > seem like a good idea to me as it would make things overcomplicated.
> >
> > It looks like it'd be simpler to use vsprintf extension %pU
[]
> > diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c b/drivers/staging/lustre/lustre/obdclass/uuid.c
[]
> > + sprintf(out->uuid, "%pU", uu);
> > }
> > EXPORT_SYMBOL(class_uuid_unparse);
>
> I agree, much better, can you resend this in a form I can apply?
Vasiliy, you started this, can you submit this
under your name please?
next prev parent reply other threads:[~2015-07-07 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-27 4:44 [PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c Vasiliy Korchagin
2015-06-27 4:53 ` Joe Perches
2015-06-27 5:36 ` Vasiliy Korchagin
2015-06-27 6:04 ` Joe Perches
2015-07-07 2:36 ` Greg KH
2015-07-07 5:01 ` Joe Perches [this message]
2015-07-15 0:40 ` [PATCH] staging: lustre: obdclass: simplify class_uuid_unparse Vasiliy Korchagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436245271.2682.32.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
--cc=vasiliy.korchagin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.