From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH OSSTEST v7 05/15] distros: support PV guest install from Debian netinst media. Date: Tue, 7 Jul 2015 10:29:54 +0100 Message-ID: <1436261394.25646.143.camel@citrix.com> References: <1432734277.14664.229.camel@citrix.com> <1432734323-14128-5-git-send-email-ian.campbell@citrix.com> <21914.38968.31589.461089@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <21914.38968.31589.461089@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Jackson Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On Mon, 2015-07-06 at 16:01 +0100, Ian Jackson wrote: > Ian Campbell writes ("[PATCH OSSTEST v7 05/15] distros: support PV guest install from Debian netinst media."): > > The netinst media are iso images containing a base Debian install and > > some (image size dependent) additional tasks. > ... > > This is configured from make*flight using runvars: > > > > - _netinst_baseurl: > > Base URL of directory containing the netinst jigdo images. > > - _netinst_filere: > > Regular expression to match actual file within baseurl to use > > (without .jigdo suffix) > > _netinst_kernel: > > Path to kernel within the netinst image > > _netinst_ramdisk > > Path to ramdisk within the netinst image > > Acked-by: Ian Jackson > > This documentation could profitably be placed in the script itself. > I've acked this anyway because existing practice is very sloppy. I did this, which implied changes to previous patches which added the script and other runvars, I have retained your ack where those were the only changes. For this specific patch I noticed an unused _cd thing while documenting, which I have removed, hence I didn't take the ack above. Ian.