All of lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: David Binderman <dcb314@hotmail.com>,
	Animesh Manna <animesh.manna@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ?
Date: Tue, 07 Jul 2015 17:33:23 +0300	[thread overview]
Message-ID: <1436279603.1830.23.camel@intel.com> (raw)
In-Reply-To: <DUB128-W3305172EB720838C0620CF9C920@phx.gbl>

On ti, 2015-07-07 at 10:51 +0000, David Binderman wrote:
> Hello there,
> 
> [linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353]: (warning) Logical conjunction always evaluates to false: EXPR < 524288 && EXPR> 589823.
> 
> Source code is
> 
>       if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE &&
>             dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
> 
> Maybe better code
> 
>       if (dmc_header->mmioaddr[i] < CSR_MMIO_START_RANGE ||
>             dmc_header->mmioaddr[i]> CSR_MMIO_END_RANGE) {
> 
> Regards
> 
> David Binderman

Thanks for reporting it, review fail on my side. Animesh could you send
a patch to fix this up?

Thanks,
Imre

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-07-07 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-07 10:51 linux-4.2-rc1/drivers/gpu/drm/i915/intel_csr.c:353: bad if statement ? David Binderman
2015-07-07 14:33 ` Imre Deak [this message]
2015-07-08  5:32   ` Manna, Animesh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1436279603.1830.23.camel@intel.com \
    --to=imre.deak@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dcb314@hotmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.