From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: [PATCH v2 1/3] xen/domain_page: Convert map_domain_page_global() to using mfn_t Date: Tue, 7 Jul 2015 16:12:09 +0100 Message-ID: <1436281929.25646.241.camel@citrix.com> References: <1435838656-9219-1-git-send-email-Ben.Catterall@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZCUZP-0001Kf-DF for xen-devel@lists.xenproject.org; Tue, 07 Jul 2015 15:14:03 +0000 In-Reply-To: <1435838656-9219-1-git-send-email-Ben.Catterall@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ben Catterall Cc: keir@xen.org, andrew.cooper3@citrix.com, tim@xen.org, stefano.stabellini@citrix.com, jbeulich@suse.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On Thu, 2015-07-02 at 13:04 +0100, Ben Catterall wrote: > From: Andrew Cooper > > The sh_map/unmap wrappers can be dropped, and take the opportunity to turn > some #define's into static inlines, for added type saftey. > > As part of adding the type safety, GCC highlights an problematic include cycle > with arm/mm.h including domain_page.h which includes xen/mm.h and falls over > __page_to_mfn being used before being declared. Simply dropping the inclusion > of domain_page.h fixes the compilation issue. > > Signed-off-by: Andrew Cooper > CC: Jan Beulich > CC: Tim Deegan For ARM: Acked-by: Ian Campbell