From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3 for Xen 4.6 4/4] xl: enable per-VCPU parameter settings for RTDS scheduler Date: Tue, 7 Jul 2015 17:34:27 +0200 Message-ID: <1436283266.22672.132.camel@citrix.com> References: <1435545899-22751-1-git-send-email-chong.li@wustl.edu> <1435545899-22751-5-git-send-email-chong.li@wustl.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4846564867642511934==" Return-path: In-Reply-To: <1435545899-22751-5-git-send-email-chong.li@wustl.edu> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chong Li Cc: Chong Li , wei.liu2@citrix.com, Sisu Xi , george.dunlap@eu.citrix.com, xen-devel@lists.xen.org, Meng Xu , dgolomb@seas.upenn.edu List-Id: xen-devel@lists.xenproject.org --===============4846564867642511934== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-HdYqcir+ny/V695C8Lfm" --=-HdYqcir+ny/V695C8Lfm Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, 2015-06-28 at 21:44 -0500, Chong Li wrote: > Change main_sched_rtds and related output functions to support per-VCPU s= ettings. >=20 > Changes on PATCH v2: >=20 > 1) Remove per-domain output functions for RTDS scheduler. >=20 > 2) Users now use '-v all' to specify all VCPUs. >=20 > 3) Support outputting a subset of the parameters of the VCPUs of a specif= ic domain. >=20 > 4) When setting all VCPUs with the same parameters (by only one command),= no per-domain function is invoked. >=20 > Signed-off-by: Chong Li > Signed-off-by: Meng Xu > Signed-off-by: Sisu Xi >=20 I think this patch is fine. I've asked already, when replying to the cover message, what happens if one uses just: # xl sched-rtds or # xl sched-rtds -d vm1 and it looks to me that, instead of getting rid of sched_rtds_domain_output(), you can leave it there and make it respond to the above calls, with the effect of returning the default values, as agreed and implemented. What do you think? If not done like this (and if I'm not missing something), is there a way to retrieve those values from xl? Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-HdYqcir+ny/V695C8Lfm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEABECAAYFAlWb8YMACgkQk4XaBE3IOsSBRACeJYn47nhPKhk0G05OZXqGqLjv m40AnjRPmS94D/DQ86zZ0uPF6JZTH3Em =y/UA -----END PGP SIGNATURE----- --=-HdYqcir+ny/V695C8Lfm-- --===============4846564867642511934== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============4846564867642511934==--