* Patch "usb: gadget: f_fs: fix check in read operation" has been added to the 4.0-stable tree
@ 2015-07-07 17:33 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2015-07-07 17:33 UTC (permalink / raw)
To: rui.silva, balbi, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
usb: gadget: f_fs: fix check in read operation
to the 4.0-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
usb-gadget-f_fs-fix-check-in-read-operation.patch
and it can be found in the queue-4.0 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 342f39a6c8d34d638a87b7d5f2156adc4db2585c Mon Sep 17 00:00:00 2001
From: Rui Miguel Silva <rui.silva@linaro.org>
Date: Wed, 20 May 2015 14:53:33 +0100
Subject: usb: gadget: f_fs: fix check in read operation
From: Rui Miguel Silva <rui.silva@linaro.org>
commit 342f39a6c8d34d638a87b7d5f2156adc4db2585c upstream.
when copying to iter the size can be different then the iov count,
the check for full iov is wrong and make any read on request which
is not the exactly size of iov to return -EFAULT.
So, just check the success of the copy.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/usb/gadget/function/f_fs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/usb/gadget/function/f_fs.c
+++ b/drivers/usb/gadget/function/f_fs.c
@@ -845,7 +845,7 @@ static ssize_t ffs_epfile_io(struct file
ret = ep->status;
if (io_data->read && ret > 0) {
ret = copy_to_iter(data, ret, &io_data->data);
- if (unlikely(iov_iter_count(&io_data->data)))
+ if (!ret)
ret = -EFAULT;
}
}
Patches currently in stable-queue which might be from rui.silva@linaro.org are
queue-4.0/usb-gadget-f_fs-fix-check-in-read-operation.patch
queue-4.0/usb-gadget-f_fs-add-extra-check-before-unregister_gadget_item.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-07-07 17:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-07 17:33 Patch "usb: gadget: f_fs: fix check in read operation" has been added to the 4.0-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.