From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>,
x86@kernel.org, linux-kernel@vger.kernel.org,
Ingo Molnar <mingo@redhat.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v1 1/4] iosf_mbi: check result for all calls of debugfs API
Date: Wed, 8 Jul 2015 12:32:50 +0300 [thread overview]
Message-ID: <1436347973-50436-2-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <1436347973-50436-1-git-send-email-andriy.shevchenko@linux.intel.com>
While here, replase IS_ERR_OR_NULL(x) to just !x since first one does the job
for us.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/x86/kernel/iosf_mbi.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/iosf_mbi.c b/arch/x86/kernel/iosf_mbi.c
index 82f8d02..2362da9 100644
--- a/arch/x86/kernel/iosf_mbi.c
+++ b/arch/x86/kernel/iosf_mbi.c
@@ -240,17 +240,17 @@ static void iosf_sideband_debug_init(void)
/* mdr */
d = debugfs_create_x32("mdr", 0660, iosf_dbg, &dbg_mdr);
- if (IS_ERR_OR_NULL(d))
+ if (!d)
goto cleanup;
/* mcrx */
- debugfs_create_x32("mcrx", 0660, iosf_dbg, &dbg_mcrx);
- if (IS_ERR_OR_NULL(d))
+ d = debugfs_create_x32("mcrx", 0660, iosf_dbg, &dbg_mcrx);
+ if (!d)
goto cleanup;
/* mcr - initiates mailbox tranaction */
- debugfs_create_file("mcr", 0660, iosf_dbg, &dbg_mcr, &iosf_mcr_fops);
- if (IS_ERR_OR_NULL(d))
+ d = debugfs_create_file("mcr", 0660, iosf_dbg, &dbg_mcr, &iosf_mcr_fops);
+ if (!d)
goto cleanup;
return;
--
2.1.4
next prev parent reply other threads:[~2015-07-08 9:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 9:32 [PATCH v1 0/4] iosf_mbi: clean up Andy Shevchenko
2015-07-08 9:32 ` Andy Shevchenko [this message]
2015-07-08 9:49 ` [PATCH v1 1/4] iosf_mbi: check result for all calls of debugfs API Thomas Gleixner
2015-07-08 10:02 ` Andy Shevchenko
2015-07-08 9:32 ` [PATCH v1 2/4] iosf_mbi: pci_dev_put() is NULL-proof Andy Shevchenko
2015-07-08 9:32 ` [PATCH v1 3/4] iosf_mbi: group global variables Andy Shevchenko
2015-07-08 9:32 ` [PATCH v1 4/4] iosf_mbi: append Intel Tangier ID Andy Shevchenko
2015-07-08 9:36 ` [PATCH v1 0/4] iosf_mbi: clean up Ingo Molnar
2015-07-08 9:52 ` Thomas Gleixner
2015-07-08 10:00 ` Andy Shevchenko
2015-07-08 10:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436347973-50436-2-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.