From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH v5 2/3] arm: Allow the user to specify the
	GIC version
Date: Wed, 8 Jul 2015 11:17:43 +0100
Message-ID: <1436350663.25646.286.camel@citrix.com>
References: <1436286154-15696-1-git-send-email-julien.grall@citrix.com>
	<1436286154-15696-3-git-send-email-julien.grall@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=624374659=Ian.Campbell@citrix.com>)
	id 1ZCmQH-0001Li-KB
	for xen-devel@lists.xenproject.org; Wed, 08 Jul 2015 10:17:49 +0000
In-Reply-To: <1436286154-15696-3-git-send-email-julien.grall@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@citrix.com>
Cc: xen-devel@lists.xenproject.org, stefano.stabellini@citrix.com, Ian Jackson <ian.jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-07 at 17:22 +0100, Julien Grall wrote:
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index e1632fa..11f6461 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -369,6 +369,12 @@ libxl_vnode_info = Struct("vnode_info", [
>      ("vcpus", libxl_bitmap), # vcpus in this node
>      ])
>  
> +libxl_gic_version = Enumeration("gic_version", [
> +    (0, "DEFAULT"),
> +    (0x20, "v2"),
> +    (0x30, "v3")
> +    ], init_val = "LIBXL_GIC_VERSION_DEFAULT")
> +
>  libxl_domain_build_info = Struct("domain_build_info",[
>      ("max_vcpus",       integer),
>      ("avail_vcpus",     libxl_bitmap),
> @@ -480,6 +486,11 @@ libxl_domain_build_info = Struct("domain_build_info",[
>                                        ])),
>                   ("invalid", None),
>                   ], keyvar_init_val = "LIBXL_DOMAIN_TYPE_INVALID")),
> +
> +
> +    ("arch_arm", Struct(None, [("gic_version", libxl_gic_version),
> +                              ])),
> +
>      ], dir=DIR_IN

This results in the following when building the ocaml bindings:

Traceback (most recent call last):
  File "genwrap.py", line 529, in <module>
    ml.write(gen_ocaml_ml(ty, False))
  File "genwrap.py", line 217, in gen_ocaml_ml
    s += gen_struct(ty)
  File "genwrap.py", line 119, in gen_struct
    x = ocaml_instance_of_field(f)
  File "genwrap.py", line 112, in ocaml_instance_of_field
    return "%s : %s" % (munge_name(name), ocaml_type_of(f.type))
  File "genwrap.py", line 90, in ocaml_type_of
    return ty.rawname.capitalize() + ".t"
AttributeError: 'NoneType' object has no attribute 'capitalize'
make[7]: *** No rule to make target '_libxl_types.ml.in', needed by 'xenlight.ml'.  Stop.

I'll take a look.