From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH V3] libxc: Prevent NULL pointer dereference
 in stdiostream_vmessage()
Date: Wed, 8 Jul 2015 13:43:54 +0100
Message-ID: <1436359434.23508.33.camel@citrix.com>
References: <1436287139-40700-1-git-send-email-Jennifer.Herbert@citrix.com>
	<21916.355.525251.376448@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21916.355.525251.376448@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, Jennifer Herbert <Jennifer.Herbert@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Tue, 2015-07-07 at 17:42 +0100, Ian Jackson wrote:
> Jennifer Herbert writes ("[PATCH V3] libxc: Prevent NULL pointer dereference in stdiostream_vmessage()"):
> > Unlikely that it may seem localtime_r could fail, which would result in a
> > null pointer dereference.  In this case, it shoud log the errno, (instead of
> > the date/time), and and continue its logging, as this is still useful.
> > 
> > Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Applied.