From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dario Faggioli <dario.faggioli@citrix.com>
Subject: Re: [PATCH] x86: correct socket_cpumask allocation for
 AP
Date: Thu, 9 Jul 2015 10:39:51 +0200
Message-ID: <1436431191.22672.277.camel@citrix.com>
References: <1436348218-29172-1-git-send-email-chao.p.peng@linux.intel.com>
	<559D35FD020000780008E354@mail.emea.novell.com>
	<1436368264.22672.219.camel@citrix.com>
	<559D602C020000780008E585@mail.emea.novell.com>
	<1436372256.22672.246.camel@citrix.com>
	<559D6CAC020000780008E667@mail.emea.novell.com>
	<20150709015812.GG3333@pengc-linux.bj.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4737453068689610024=="
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20150709015812.GG3333@pengc-linux.bj.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Chao Peng <chao.p.peng@linux.intel.com>
Cc: andrew.cooper3@citrix.com, Boris Ostrovsky <boris.ostrovsky@oracle.com>, keir@xen.org, Jan Beulich <JBeulich@suse.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

--===============4737453068689610024==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="=-JGNUv3oSnE/Ip878j2Sx"

--=-JGNUv3oSnE/Ip878j2Sx
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2015-07-09 at 09:58 +0800, Chao Peng wrote:
> On Wed, Jul 08, 2015 at 05:32:11PM +0100, Jan Beulich wrote:
> > >>> On 08.07.15 at 18:17, <dario.faggioli@citrix.com> wrote:
> > > I think it has to do with the fact that I've got CPU #0 on socket #1,
> > > while Boris' (and perhaps Chao's too) test box have it on socket #0.
> >=20
> > Ah, yes, this is indeed a case I didn't consider when validating
> > Chao's analysis.
>=20
> I apologize, this is what I have made the wrong assumption on
> from the beginning.
>
Yes, it's quite easy to get caught by this, I've been in similar
situation too (i.e., with code working in completely different ways
depending on whether CPU#0 was on socket 0 or not). :-)

> While looks the fix is simple, just change
> 'zalloc_cpumask_var(socket_cpumask)' to
> 'zalloc_cpumask_var(socket_cpumask + cpu_to_socket(0))'
> for booting cpu in smp_prepare_cpus().
>=20
FWIW, I can confirm that doing this (on top of the already submitted
patch) makes the issue go away on my hardware.

I can't verify whether things are working properly, though, as I don't
have any CAT enabled system handy.

Regards,
Dario

--=20
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

--=-JGNUv3oSnE/Ip878j2Sx
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEABECAAYFAlWeM18ACgkQk4XaBE3IOsSfBgCbBQZZV9FN4qzRi7tVqnjbMO22
bssAn1urVlB2aU7ipP5Kr3He5aUnDSHY
=ba6p
-----END PGP SIGNATURE-----

--=-JGNUv3oSnE/Ip878j2Sx--


--===============4737453068689610024==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

--===============4737453068689610024==--