From: Ian Campbell <ian.campbell@citrix.com>
To: Dave Scott <Dave.Scott@citrix.com>
Cc: Julien Grall <julien.grall@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>,
Wei Liu <wei.liu2@citrix.com>, Rob Hoes <Rob.Hoes@citrix.com>,
"<xen-devel@lists.xen.org>" <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: ocaml: Handle anonymous struct members of structs in libxl IDL
Date: Thu, 9 Jul 2015 12:55:32 +0100 [thread overview]
Message-ID: <1436442932.23508.120.camel@citrix.com> (raw)
In-Reply-To: <2040CDDB-1935-4967-B35F-D4DF33D40F66@citrix.com>
On Thu, 2015-07-09 at 12:02 +0100, Dave Scott wrote:
> > As said on another thread, I’m not a fan of the __anon suffix. But I
> won’t object either, because in practice it doesn’t really matter.
Right, I kept it for consistency with the __union suffix elsewhere, but
perhaps we should consider removing both at some point.
> So:
> >
> > Acked-by: Rob Hoes <rob.hoes@citrix.com>
>
> This is also ok by me, so
>
> Acked-by: David Scott <dave.scott@citrix.com>
Applied, thanks.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2015-07-09 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-08 14:29 [PATCH] tools: ocaml: Handle anonymous struct members of structs in libxl IDL Ian Campbell
2015-07-09 10:29 ` Ian Jackson
2015-07-09 10:59 ` Rob Hoes
2015-07-09 11:02 ` Dave Scott
2015-07-09 11:55 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1436442932.23508.120.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Dave.Scott@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=Rob.Hoes@citrix.com \
--cc=julien.grall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.