diff for duplicates of <1436445274.25102.0.camel@codethink.co.uk> diff --git a/a/1.txt b/N1/1.txt index ef27620..c4ad8ec 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -15,8 +15,7 @@ On Fri, 2015-07-03 at 00:21 +0100, Ben Hutchings wrote: > > > + PORT_GP_32(3, PIN_IO_VOLTAGE, unused), > > > + > > > + /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> > > + [RCAR_GP_PIN(5, 31) + 1] = -> > +> > > + [RCAR_GP_PIN(5, 31) + 1] > > > > I'm sorry but I still don't like this. gcc outputs a warning when overriding > > an initializer if you enable -Wextra, which leads me to believe this construct > > is dubious. It should at least be tested with LLVM. @@ -122,8 +121,7 @@ Ben. > + PORT_GP_32(5, _GP_GPIO, unused), > > /* Pins not associated with a GPIO port, placed after all the GPIOs */ -> - [RCAR_GP_PIN(5, 31) + 1] = -> SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), +> - [RCAR_GP_PIN(5, 31) + 1] > SH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15), > SH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15), > SH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15), > diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c diff --git a/a/content_digest b/N1/content_digest index 9fcd48b..821fa5b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -4,7 +4,7 @@ "ref\01435879310.7541.2.camel@codethink.co.uk\0" "From\0Ben Hutchings <ben.hutchings@codethink.co.uk>\0" "Subject\0Re: [PATCH v4 2/8] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI\0" - "Date\0Thu, 09 Jul 2015 13:34:34 +0100\0" + "Date\0Thu, 09 Jul 2015 12:34:34 +0000\0" "To\0Laurent Pinchart <laurent.pinchart@ideasonboard.com>\0" "Cc\0Ian Molton <ian@mnementh.co.uk>" linux-mmc@vger.kernel.org @@ -33,8 +33,7 @@ "> > > +\tPORT_GP_32(3, PIN_IO_VOLTAGE, unused),\n" "> > > +\n" "> > > +\t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "> > > +\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "> > \n" + "> > > +\t[RCAR_GP_PIN(5, 31) + 1] > > \n" "> > I'm sorry but I still don't like this. gcc outputs a warning when overriding \n" "> > an initializer if you enable -Wextra, which leads me to believe this construct \n" "> > is dubious. It should at least be tested with LLVM.\n" @@ -140,8 +139,7 @@ "> +\tPORT_GP_32(5, _GP_GPIO, unused),\n" "> \n" "> \t/* Pins not associated with a GPIO port, placed after all the GPIOs */\n" - "> -\t[RCAR_GP_PIN(5, 31) + 1] =\n" - "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" + "> -\t[RCAR_GP_PIN(5, 31) + 1] > \tSH_PFC_PIN_NAMED(ROW_GROUP_A('F'), 15, AF15),\n" "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('G'), 15, AG15),\n" "> \tSH_PFC_PIN_NAMED(ROW_GROUP_A('H'), 15, AH15),\n" "> diff --git a/drivers/pinctrl/sh-pfc/pfc-sh73a0.c b/drivers/pinctrl/sh-pfc/pfc-sh73a0.c\n" @@ -208,4 +206,4 @@ "> Ben.\n" > -5d5e942aa8a4398091fd0db2596663afab2da6be1c713c77df572184577b418e +417d671d80f1a859dfacbe907e302e703fb0d1f66174d82d32a699c6dc4fa76c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.