From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH OSSTEST v7 1/2] cr-publish-flight-logs:
 support publishing files from $HOME/public_html
Date: Thu, 9 Jul 2015 14:54:27 +0100
Message-ID: <1436450067.23508.133.camel@citrix.com>
References: <1436443165-13837-1-git-send-email-ian.campbell@citrix.com>
	<21918.28032.605611.97888@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21918.28032.605611.97888@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On Thu, 2015-07-09 at 13:48 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v7 1/2] cr-publish-flight-logs: support publishing files from $HOME/public_html"):
> > Any arguments given after the flight are assumed to be files or
> > directories relative to $HOME/public_html which should be published to
> > $c{Publish} at the same relative path.
> > 
> > Removing the requirement that a flight be provided, by accepting '',
> > allows this to be used even in contexts which have no flight.
> > 
> > The results subtree is always published if $c{ResultsPublish} is set,
> > since it doesn't depend on any particular flight.
> 
> Uh.  Looking at this, I hadn't spotted that in your other patch you
> generate the output in ~/public_html.  Shouldn't it be in results/
> (which is nowadays a general place for publicly visible output) ?
> 
> At the very least, if you do mean ~/public_html, you should be using
> WebspaceFile.

Results would be ok too, if you prefer (which you seem to so I shall
make that change).

> 
> Also:
> 
> > -sub copydir ($$) {
> > +sub copylogs ($$) {
> 
> Why did you rename this function ?

I meant to mention this in the commit message and forgot, it was just
because the thing I was now copying wasn't a dir...

But if I generate the file into results this isn't need, the existing
publication of Results will do the job for free.

Ian.